You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/06/18 20:17:44 UTC
Review Request 22746: Avoiding cluster-wide query in case hosts-scoped call
did not produce any tasks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22746/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
Bugs: AURORA-537
https://issues.apache.org/jira/browse/AURORA-537
Repository: aurora
Description
-------
Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.
Diffs
-----
src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703
src/main/python/apache/aurora/client/api/sla.py a7b876094a5ab0d06ec6a191c7aec2a1058a9c1c
src/test/python/apache/aurora/client/api/test_sla.py 9ca810262f23b0d5b9672bc92eb4edb2f2178fd0
Diff: https://reviews.apache.org/r/22746/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/api:sla
Thanks,
Maxim Khutornenko
Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped
call did not produce any tasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22746/#review46275
-----------------------------------------------------------
Ping.
- Maxim Khutornenko
On June 18, 2014, 6:17 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22746/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 6:17 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
>
>
> Bugs: AURORA-537
> https://issues.apache.org/jira/browse/AURORA-537
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703
> src/main/python/apache/aurora/client/api/sla.py a7b876094a5ab0d06ec6a191c7aec2a1058a9c1c
> src/test/python/apache/aurora/client/api/test_sla.py 9ca810262f23b0d5b9672bc92eb4edb2f2178fd0
>
> Diff: https://reviews.apache.org/r/22746/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:sla
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped
call did not produce any tasks.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22746/#review46310
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On June 18, 2014, 2:17 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22746/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 2:17 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
>
>
> Bugs: AURORA-537
> https://issues.apache.org/jira/browse/AURORA-537
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703
> src/main/python/apache/aurora/client/api/sla.py a7b876094a5ab0d06ec6a191c7aec2a1058a9c1c
> src/test/python/apache/aurora/client/api/test_sla.py 9ca810262f23b0d5b9672bc92eb4edb2f2178fd0
>
> Diff: https://reviews.apache.org/r/22746/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:sla
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped
call did not produce any tasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 20, 2014, 5:16 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/api/sla.py, line 315
> > <https://reviews.apache.org/r/22746/diff/1/?file=612444#file612444line315>
> >
> > This seems comment-worthy to hopefully avoid being bitten again.
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22746/#review46290
-----------------------------------------------------------
On June 18, 2014, 6:17 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22746/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 6:17 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
>
>
> Bugs: AURORA-537
> https://issues.apache.org/jira/browse/AURORA-537
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703
> src/main/python/apache/aurora/client/api/sla.py a7b876094a5ab0d06ec6a191c7aec2a1058a9c1c
> src/test/python/apache/aurora/client/api/test_sla.py 9ca810262f23b0d5b9672bc92eb4edb2f2178fd0
>
> Diff: https://reviews.apache.org/r/22746/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:sla
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped
call did not produce any tasks.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22746/#review46290
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/api/sla.py
<https://reviews.apache.org/r/22746/#comment81597>
This seems comment-worthy to hopefully avoid being bitten again.
- Bill Farner
On June 18, 2014, 6:17 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22746/
> -----------------------------------------------------------
>
> (Updated June 18, 2014, 6:17 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
>
>
> Bugs: AURORA-537
> https://issues.apache.org/jira/browse/AURORA-537
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703
> src/main/python/apache/aurora/client/api/sla.py a7b876094a5ab0d06ec6a191c7aec2a1058a9c1c
> src/test/python/apache/aurora/client/api/test_sla.py 9ca810262f23b0d5b9672bc92eb4edb2f2178fd0
>
> Diff: https://reviews.apache.org/r/22746/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/client/api:sla
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 22746: Avoiding cluster-wide query in case hosts-scoped
call did not produce any tasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22746/
-----------------------------------------------------------
(Updated June 20, 2014, 11:09 p.m.)
Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
Changes
-------
CR comments.
Bugs: AURORA-537
https://issues.apache.org/jira/browse/AURORA-537
Repository: aurora
Description
-------
Avoiding cluster-wide query in case hosts-scoped call did not produce any tasks.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/host_maintenance.py 97d484fc29b8cd0ff1f2c7ae6624d598a0b7f703
src/main/python/apache/aurora/client/api/sla.py a7b876094a5ab0d06ec6a191c7aec2a1058a9c1c
src/test/python/apache/aurora/client/api/test_sla.py 9ca810262f23b0d5b9672bc92eb4edb2f2178fd0
Diff: https://reviews.apache.org/r/22746/diff/
Testing
-------
./pants src/test/python/apache/aurora/client/api:sla
Thanks,
Maxim Khutornenko