You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/09 01:13:01 UTC
[GitHub] [incubator-nuttx-apps] ttnie opened a new pull request #410: Add LTP support
ttnie opened a new pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410
## Summary
Add LTP support
## Impact
## Testing
test on local environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704308788
@ttnie is it ready to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704926804
@justinmclean Can you please clarify this. Particularly the phrase "ASF projects also can't have a dependancy on GPL code either."
>
> Just trying to understand the GPL comment above. The GPL license is not compatible with the Apache one and we can't have GPL code in our repo. ASF projects also can't have a dependancy on GPL code either. Is this the case with this PR?
This PR would download and build the GPL Linux Test Program into NuttX at build time. So, even if they work around the issues of the GPL patches, the binaries built with option would include GPL code. Is this a "dependency on GPL"? It seems so to me.
There are several other places where this download trick is used to download third part code into NuttX binaries at build time. This is done to avoid ASF third party rules, to avoid conformance with the NuttX coding standard, and to deal with third party code that is undergoing changes. It would be good to understand if the ASF has any restrictions or thoughts on this practice -- with both compatible and incompatible licenses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705209930
>
>
> Now in general using non compatible licenses for testing is fine as no incapable nothing ends up in the final source or binary release. e.g JUnit But it seem like this issue may be more similar with one of the MXNet issue it that GPL licensed code ends up in the binary. Is this correct? If so there is a dependency on GPL and would not be allowed unless it's an optional feature that is not built by default and the user is made aware of the licensing implication if they do enable it.
@justinmclean We don't release binaries and the GPL code would not be present in the source releases either. In the build process, the GPL source would be automatically downloaded on demand and built into the binaries by the user. This code would not be downloaded or built in the _normal_ OS build; it would only be included the if the user were making test-related build and if the user explicitly selected inclusion of the GPL code from a configuration menu.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r542341749
##########
File path: testing/ltp/Makefile
##########
@@ -0,0 +1,113 @@
+
+# apps/testing/ltp/ltp/Makefile
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+include $(APPDIR)/Make.defs
+
+LTP_UNPACK = ltp
+LTP_URL = https://github.com/linux-test-project/ltp.git
+
+TESTDIR = $(LTP_UNPACK)/testcases/open_posix_testsuite
+
+ifeq ($(CONFIG_FS_AIO),)
+BLACKWORDS += "aio.h"
+BLACKWORDS += "SIGPOLL"
+endif
+BLACKWORDS += "affinity.h"
+BLACKWORDS += "langinfo.h"
+BLACKWORDS += "ucontext.h"
+BLACKWORDS += "noatime.h"
+BLACKWORDS += "CLOCK_PROCESS_CPUTIME_ID"
+BLACKWORDS += "CLOCK_THREAD_CPUTIME_ID"
+BLACKWORDS += "fork()"
+BLACKWORDS += "pthread_attr_setscope"
+BLACKWORDS += "RLIMIT_MEMLOCK"
+BLACKWORDS += "PTHREAD_SCOPE_PROCESS"
+BLACKWORDS += "SIGABRT"
+BLACKWORDS += "SIGBUS"
+BLACKWORDS += "SIGFPE"
+BLACKWORDS += "SIGHUP"
+BLACKWORDS += "SIGILL"
+BLACKWORDS += "SIGPROF"
+BLACKWORDS += "SIGSEGV"
+BLACKWORDS += "SIGSYS"
+BLACKWORDS += "SIGTRAP"
+BLACKWORDS += "SIGTSTP"
+BLACKWORDS += "SIGTTIN"
+BLACKWORDS += "SIGTTOU"
+BLACKWORDS += "SIGURG"
+BLACKWORDS += "SIGVTALRM"
+BLACKWORDS += "SIGXCPU"
+BLACKWORDS += "SIGXFSZ"
+BLACKWORDS += "SIGSTKSZ"
+BLACKWORDS += "stack_t"
+BLACKWORDS += "siginterrupt"
+BLACKWORDS += "threads_scenarii.c"
+
+BLACKWORDS += "ILL_[A-Z]"
+BLACKWORDS += "FPE_[A-Z]"
+BLACKWORDS += "BUS_[A-Z]"
+BLACKWORDS += "TRAP_[A-Z]"
+BLACKWORDS += "SEGV_[A-Z]"
+BLACKWORDS += "POLL_[A-Z]"
+BLACKWORDS += "SA_ONSTACK"
+BLACKWORDS += "MINSIGSTKSZ"
+BLACKWORDS += "FPE_FLTINV"
+
+BLACKSRCS += testfrmw.c
+BLACKSRCS += 7-3-buildonly.c
+BLACKSRCS += 7-4-buildonly.c
+BLACKSRCS += 7-5-buildonly.c
+BLACKSRCS += 11-1-buildonly.c
+BLACKSRCS += 17-1-buildonly.c
+BLACKSRCS += 19-1-buildonly.c
+BLACKSRCS += 21-1-buildonly.c
+BLACKSRCS += 22-31-buildonly.c
+BLACKSRCS += 22-32-buildonly.c
+BLACKSRCS += 25-1-buildonly.c
+BLACKSRCS += 27-1-buildonly.c
+BLACKSRCS += 35-1-buildonly.c
+BLACKSRCS += 35-2-buildonly.c
+
+MAINWORDS += "main("
+
+LTP_ORIGINS := $(shell find $(TESTDIR) -name *.c)
+
+$(foreach word, $(BLACKWORDS), $(eval BLACKLIST+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+$(foreach src, $(BLACKSRCS), $(eval BLACKLIST+=$(filter %$(src),$(LTP_ORIGINS))))
+
+LTP_ORIGINS := $(filter-out $(BLACKLIST), $(LTP_ORIGINS))
+
+$(foreach word, $(MAINWORDS), $(eval LTP_MAINCSRCS+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+
+LTP_CSRCS := $(filter-out $(LTP_MAINCSRCS), $(LTP_ORIGINS))
+
+PROGNAME := $(basename $(shell echo $(LTP_MAINCSRCS) | xargs -n 1 | awk -F "[/]" '{print "ltp_"$$(NF-2)"_"$$(NF-1)"_"$$(NF)}' | sed s/-/_/g))
+MAINSRC = $(LTP_MAINCSRCS)
+PRIORITY = SCHED_PRIORITY_DEFAULT
+STACKSIZE = $(CONFIG_DEFAULT_TASK_STACKSIZE)
+MODULE = $(CONFIG_TESTING_LTP)
+
+CSRCS := $(LTP_CSRCS)
+CFLAGS += -I$(LTP_UNPACK)
+CFLAGS += -I$(TESTDIR)/include
+
+$(LTP_UNPACK):
+ $(Q) echo "git clone $(LTP_URL)"
+ $(Q) git clone $(LTP_URL)
+
+context:: $(LTP_UNPACK)
+
+
Review comment:
need add distclean to keep git status clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705908365
> @ttnie is it ready to merge?
@acassis back from holiday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] justinmclean commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
justinmclean commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704695863
Just trying to understand the GPL comment above. The GPL license is not compatible with the Apache one and we can't have GPL code in our repo. ASF projects also can't have a dependancy on GPL code either. Is this the case with this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704359576
> @ttnie is it ready to merge?
@acassis there are few compiling warnings need to resolve before merging. We ares in China Nation Holiday, the progress is a little bit slow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704697785
The this PR would enable users to optionally include the LTP as an application. To do so requires a very large patch applied (included in the PR) to what the user would choose to download.
That is why I had raised the issue about accepting this PR. The contents of the patch are being upstreamed to the LTP project. Once that is done we should be able to accept this as the GPL code will only be included if the user chooses to download it in addition to our Apache release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r496742896
##########
File path: testing/ltp/Make.defs
##########
@@ -0,0 +1,39 @@
+############################################################################
+# apps/testing/Make.defs
Review comment:
@acassis Thanks for your reminder, update done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704404617
> > @ttnie is it ready to merge?
>
> @acassis there are few compiling warnings need to resolve before merging. We ares in China Nation Holiday, the progress is a little bit slow.
Hi @xiaoxiang781216 I'm sorry, I forgot about it. When people will return? By Thursday?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704357140
> It's 20k lines of GPL we cannot have that in the Apache release bundle. Also it's not clear to me how we would maintain it.
@btashton all changes aren't specific to NuttX, @ttnie and @PeterBee97 is preparing to upstream the patch to mainline. LTP is the essential part of the automation test infrastructure @ttnie is preparing to upstream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-716325357
> In Linux, each test case build into a separated ELF binary, but NuttX build all soruces into one big image(execpt we enable ELF binfmt). So the linker complain the duplicated symbols on NuttX. But anyway, it's always a good egnineering practice to limit the symbol scope as small as possible even it isn't so critical on Linux.
Yeah I was wondering if we could just create standalone ELF for each, but I agree lets see if we can just improve the LTP and use that as a fallback otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705206185
Thanks @justinmclean yeah I had been watching the MXNet conversation.
Here I think we meet the Optional definition in that link. In this case a user would enable the LTP as an application specifically to test NuttX compliance with the POSIX interfaces, it would never be expected to be included in an end product using NuttX and no LTP GPL code would be included in the release.
We include some helpers in the build scripts to download the source but only if a user opts in to that feature.
The only users of this feature are likely NuttX contributors and maintainers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705209930
>
>
> Now in general using non compatible licenses for testing is fine as no incapable nothing ends up in the final source or binary release. e.g JUnit But it seem like this issue may be more similar with one of the MXNet issue it that GPL licensed code ends up in the binary. Is this correct? If so there is a dependency on GPL and would not be allowed unless it's an optional feature that is not built by default and the user is made aware of the licensing implication if they do enable it.
We don't release binaries and the GPL code would not be present in the source releases either. In the build process, the GPL source would be automatically downloaded on demand and built into the binaries by the user. This code would not be downloaded or built in the _normal_ OS build; it would only be included the if the user were making test-related build and if the user explicitly selected inclusion of the GPL code from a configuration menu.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704357140
> It's 20k lines of GPL we cannot have that in the Apache release bundle. Also it's not clear to me how we would maintain it.
The change isn't specific to NuttX, @ttnie and @PeterBee97 is preparing to upstream the patch to mainline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704986713
There are lot of other Apache projects that support being built with non allowed code such as some intel and Nvidia libraries. It is my understanding that the Apache project just still needs to be functional without it which certainly is the case here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704359576
> @ttnie is it ready to merge?
There are few compiling warnings need to resolve before merging. We ares in China Nation Holiday, the progress is a little bit slow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r496673862
##########
File path: testing/ltp/Make.defs
##########
@@ -0,0 +1,39 @@
+############################################################################
+# apps/testing/Make.defs
Review comment:
Strange, it still displaying BSD License instead of Apache, is it some issue on github?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie closed pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie closed pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-745099683
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704343906
Since it will be used only for testing and will not be included in the final product's firmware, maybe it is not a big concern. What you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543022725
##########
File path: testing/ltp/Makefile
##########
@@ -0,0 +1,117 @@
+
+# apps/testing/ltp/ltp/Makefile
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+include $(APPDIR)/Make.defs
+
+LTP_UNPACK = ltp
+LTP_URL = https://github.com/linux-test-project/ltp.git
+
+TESTDIR = $(LTP_UNPACK)/testcases/open_posix_testsuite
+
+ifeq ($(CONFIG_FS_AIO),)
+BLACKWORDS += "aio.h"
+BLACKWORDS += "SIGPOLL"
+endif
+BLACKWORDS += "affinity.h"
+BLACKWORDS += "langinfo.h"
+BLACKWORDS += "ucontext.h"
+BLACKWORDS += "noatime.h"
+BLACKWORDS += "CLOCK_PROCESS_CPUTIME_ID"
+BLACKWORDS += "CLOCK_THREAD_CPUTIME_ID"
+BLACKWORDS += "fork()"
+BLACKWORDS += "pthread_attr_setscope"
+BLACKWORDS += "RLIMIT_MEMLOCK"
+BLACKWORDS += "PTHREAD_SCOPE_PROCESS"
+BLACKWORDS += "SIGABRT"
+BLACKWORDS += "SIGBUS"
+BLACKWORDS += "SIGFPE"
+BLACKWORDS += "SIGHUP"
+BLACKWORDS += "SIGILL"
+BLACKWORDS += "SIGPROF"
+BLACKWORDS += "SIGSEGV"
+BLACKWORDS += "SIGSYS"
+BLACKWORDS += "SIGTRAP"
+BLACKWORDS += "SIGTSTP"
+BLACKWORDS += "SIGTTIN"
+BLACKWORDS += "SIGTTOU"
+BLACKWORDS += "SIGURG"
+BLACKWORDS += "SIGVTALRM"
+BLACKWORDS += "SIGXCPU"
+BLACKWORDS += "SIGXFSZ"
+BLACKWORDS += "SIGSTKSZ"
+BLACKWORDS += "stack_t"
+BLACKWORDS += "siginterrupt"
+BLACKWORDS += "threads_scenarii.c"
+
+BLACKWORDS += "ILL_[A-Z]"
+BLACKWORDS += "FPE_[A-Z]"
+BLACKWORDS += "BUS_[A-Z]"
+BLACKWORDS += "TRAP_[A-Z]"
+BLACKWORDS += "SEGV_[A-Z]"
+BLACKWORDS += "POLL_[A-Z]"
+BLACKWORDS += "SA_ONSTACK"
+BLACKWORDS += "MINSIGSTKSZ"
+BLACKWORDS += "FPE_FLTINV"
+
+BLACKSRCS += testfrmw.c
+BLACKSRCS += 7-3-buildonly.c
+BLACKSRCS += 7-4-buildonly.c
+BLACKSRCS += 7-5-buildonly.c
+BLACKSRCS += 11-1-buildonly.c
+BLACKSRCS += 17-1-buildonly.c
+BLACKSRCS += 19-1-buildonly.c
+BLACKSRCS += 21-1-buildonly.c
+BLACKSRCS += 22-31-buildonly.c
+BLACKSRCS += 22-32-buildonly.c
+BLACKSRCS += 25-1-buildonly.c
+BLACKSRCS += 27-1-buildonly.c
+BLACKSRCS += 35-1-buildonly.c
+BLACKSRCS += 35-2-buildonly.c
+
+MAINWORDS += "main("
+
+LTP_ORIGINS := $(shell find $(TESTDIR) -name *.c)
+
+$(foreach word, $(BLACKWORDS), $(eval BLACKLIST+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+$(foreach src, $(BLACKSRCS), $(eval BLACKLIST+=$(filter %$(src),$(LTP_ORIGINS))))
+
+LTP_ORIGINS := $(filter-out $(BLACKLIST), $(LTP_ORIGINS))
+
+$(foreach word, $(MAINWORDS), $(eval LTP_MAINCSRCS+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+
+LTP_CSRCS := $(filter-out $(LTP_MAINCSRCS), $(LTP_ORIGINS))
+
+PROGNAME := $(basename $(shell echo $(LTP_MAINCSRCS) | xargs -n 1 | awk -F "[/]" '{print "ltp_"$$(NF-2)"_"$$(NF-1)"_"$$(NF)}' | sed s/-/_/g))
+MAINSRC = $(LTP_MAINCSRCS)
+PRIORITY = SCHED_PRIORITY_DEFAULT
+STACKSIZE = $(CONFIG_DEFAULT_TASK_STACKSIZE)
+MODULE = $(CONFIG_TESTING_LTP)
+
+CSRCS := $(LTP_CSRCS)
+CFLAGS += -I$(LTP_UNPACK)
+CFLAGS += -I$(TESTDIR)/include
+
+$(LTP_UNPACK):
+ $(Q) echo "git clone $(LTP_URL)"
+ $(Q) git clone $(LTP_URL)
+
+context:: $(LTP_UNPACK)
+
+clean::
Review comment:
change to distclean
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704926804
@justinmclean Can you please clarify this. Particularly the phrase "ASF projects also can't have a dependancy on GPL code either."
>
> Just trying to understand the GPL comment above. The GPL license is not compatible with the Apache one and we can't have GPL code in our repo. ASF projects also can't have a dependancy on GPL code either. Is this the case with this PR?
This could would download and build the GPL Linux Test Program at build time. So, even if they work around the issues of the GPL patches, the binaries built with option would include GPL code. Is this a "dependency on GPL". It seems so to me.
There are several other places where this download trick is used to download third part code into NuttX binaries at build time. This is done to avoid ASF third party rules, to avoid conformance with the NuttX coding standard, and to deal with third party code that is undergoing changes. It would be good to understand if the ASF has any restrictions or thoughts on this practice -- with both compatible and incompatible licenses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704926804
@justinmclean Can you please clarify this. Particularly the phrase "ASF projects also can't have a dependancy on GPL code either."
>
> Just trying to understand the GPL comment above. The GPL license is not compatible with the Apache one and we can't have GPL code in our repo. ASF projects also can't have a dependancy on GPL code either. Is this the case with this PR?
This PR would download and build the GPL Linux Test Program into NuttX at build time. So, even if they work around the issues of the GPL patches, the binaries built with option would include GPL code. Is this a "dependency on GPL". It seems so to me.
There are several other places where this download trick is used to download third part code into NuttX binaries at build time. This is done to avoid ASF third party rules, to avoid conformance with the NuttX coding standard, and to deal with third party code that is undergoing changes. It would be good to understand if the ASF has any restrictions or thoughts on this practice -- with both compatible and incompatible licenses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] justinmclean commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
justinmclean commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705215655
That all sounds fine to me, thanks for the explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704411770
Friday, but people may take one ro two days vacation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705908365
> @ttnie is it ready to merge?
@acassis back from holiday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704996917
>
>
> There are lot of other Apache projects that support being built with non allowed code such as some intel and Nvidia libraries. It is my understanding that the Apache project just still needs to be functional without it which certainly is the case here.
That seems like a reasonable interpretation to me. But it would still be good to have an official ASF position.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704996917
>
>
> There are lot of other Apache projects that support being built with non allowed code such as some intel and Nvidia libraries. It is my understanding that the Apache project just still needs to be functional without it which certainly is the case here.
That seems like a reasonable interpretation to me. But it would still be good to have an official ASF position.
Proprietary licenses like Intel and Nvidia are different from GPL in that they don't have the viral properties of GPL.
I suppose the question should also be extended to included a verdict on linking with 3rd party, proprietary libraries. That is also something we will need to do to access things like proprietary wireless logic or proprietary power management logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543023140
##########
File path: testing/ltp/Makefile
##########
@@ -0,0 +1,117 @@
+
+# apps/testing/ltp/ltp/Makefile
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+include $(APPDIR)/Make.defs
+
+LTP_UNPACK = ltp
+LTP_URL = https://github.com/linux-test-project/ltp.git
+
+TESTDIR = $(LTP_UNPACK)/testcases/open_posix_testsuite
+
+ifeq ($(CONFIG_FS_AIO),)
+BLACKWORDS += "aio.h"
+BLACKWORDS += "SIGPOLL"
+endif
+BLACKWORDS += "affinity.h"
+BLACKWORDS += "langinfo.h"
+BLACKWORDS += "ucontext.h"
+BLACKWORDS += "noatime.h"
+BLACKWORDS += "CLOCK_PROCESS_CPUTIME_ID"
+BLACKWORDS += "CLOCK_THREAD_CPUTIME_ID"
+BLACKWORDS += "fork()"
+BLACKWORDS += "pthread_attr_setscope"
+BLACKWORDS += "RLIMIT_MEMLOCK"
+BLACKWORDS += "PTHREAD_SCOPE_PROCESS"
+BLACKWORDS += "SIGABRT"
+BLACKWORDS += "SIGBUS"
+BLACKWORDS += "SIGFPE"
+BLACKWORDS += "SIGHUP"
+BLACKWORDS += "SIGILL"
+BLACKWORDS += "SIGPROF"
+BLACKWORDS += "SIGSEGV"
+BLACKWORDS += "SIGSYS"
+BLACKWORDS += "SIGTRAP"
+BLACKWORDS += "SIGTSTP"
+BLACKWORDS += "SIGTTIN"
+BLACKWORDS += "SIGTTOU"
+BLACKWORDS += "SIGURG"
+BLACKWORDS += "SIGVTALRM"
+BLACKWORDS += "SIGXCPU"
+BLACKWORDS += "SIGXFSZ"
+BLACKWORDS += "SIGSTKSZ"
+BLACKWORDS += "stack_t"
+BLACKWORDS += "siginterrupt"
+BLACKWORDS += "threads_scenarii.c"
+
+BLACKWORDS += "ILL_[A-Z]"
+BLACKWORDS += "FPE_[A-Z]"
+BLACKWORDS += "BUS_[A-Z]"
+BLACKWORDS += "TRAP_[A-Z]"
+BLACKWORDS += "SEGV_[A-Z]"
+BLACKWORDS += "POLL_[A-Z]"
+BLACKWORDS += "SA_ONSTACK"
+BLACKWORDS += "MINSIGSTKSZ"
+BLACKWORDS += "FPE_FLTINV"
+
+BLACKSRCS += testfrmw.c
+BLACKSRCS += 7-3-buildonly.c
+BLACKSRCS += 7-4-buildonly.c
+BLACKSRCS += 7-5-buildonly.c
+BLACKSRCS += 11-1-buildonly.c
+BLACKSRCS += 17-1-buildonly.c
+BLACKSRCS += 19-1-buildonly.c
+BLACKSRCS += 21-1-buildonly.c
+BLACKSRCS += 22-31-buildonly.c
+BLACKSRCS += 22-32-buildonly.c
+BLACKSRCS += 25-1-buildonly.c
+BLACKSRCS += 27-1-buildonly.c
+BLACKSRCS += 35-1-buildonly.c
+BLACKSRCS += 35-2-buildonly.c
+
+MAINWORDS += "main("
+
+LTP_ORIGINS := $(shell find $(TESTDIR) -name *.c)
+
+$(foreach word, $(BLACKWORDS), $(eval BLACKLIST+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+$(foreach src, $(BLACKSRCS), $(eval BLACKLIST+=$(filter %$(src),$(LTP_ORIGINS))))
+
+LTP_ORIGINS := $(filter-out $(BLACKLIST), $(LTP_ORIGINS))
+
+$(foreach word, $(MAINWORDS), $(eval LTP_MAINCSRCS+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+
+LTP_CSRCS := $(filter-out $(LTP_MAINCSRCS), $(LTP_ORIGINS))
+
+PROGNAME := $(basename $(shell echo $(LTP_MAINCSRCS) | xargs -n 1 | awk -F "[/]" '{print "ltp_"$$(NF-2)"_"$$(NF-1)"_"$$(NF)}' | sed s/-/_/g))
+MAINSRC = $(LTP_MAINCSRCS)
+PRIORITY = SCHED_PRIORITY_DEFAULT
+STACKSIZE = $(CONFIG_DEFAULT_TASK_STACKSIZE)
+MODULE = $(CONFIG_TESTING_LTP)
+
+CSRCS := $(LTP_CSRCS)
+CFLAGS += -I$(LTP_UNPACK)
+CFLAGS += -I$(TESTDIR)/include
+
+$(LTP_UNPACK):
+ $(Q) echo "git clone $(LTP_URL)"
+ $(Q) git clone $(LTP_URL)
+
+context:: $(LTP_UNPACK)
+
+clean::
+ $(call DELFILE, .built)
+ $(call CLEAN)
Review comment:
remove,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543025307
##########
File path: testing/ltp/Makefile
##########
@@ -0,0 +1,117 @@
+
+# apps/testing/ltp/ltp/Makefile
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+include $(APPDIR)/Make.defs
+
+LTP_UNPACK = ltp
+LTP_URL = https://github.com/linux-test-project/ltp.git
+
+TESTDIR = $(LTP_UNPACK)/testcases/open_posix_testsuite
+
+ifeq ($(CONFIG_FS_AIO),)
+BLACKWORDS += "aio.h"
+BLACKWORDS += "SIGPOLL"
+endif
+BLACKWORDS += "affinity.h"
+BLACKWORDS += "langinfo.h"
+BLACKWORDS += "ucontext.h"
+BLACKWORDS += "noatime.h"
+BLACKWORDS += "CLOCK_PROCESS_CPUTIME_ID"
+BLACKWORDS += "CLOCK_THREAD_CPUTIME_ID"
+BLACKWORDS += "fork()"
+BLACKWORDS += "pthread_attr_setscope"
+BLACKWORDS += "RLIMIT_MEMLOCK"
+BLACKWORDS += "PTHREAD_SCOPE_PROCESS"
+BLACKWORDS += "SIGABRT"
+BLACKWORDS += "SIGBUS"
+BLACKWORDS += "SIGFPE"
+BLACKWORDS += "SIGHUP"
+BLACKWORDS += "SIGILL"
+BLACKWORDS += "SIGPROF"
+BLACKWORDS += "SIGSEGV"
+BLACKWORDS += "SIGSYS"
+BLACKWORDS += "SIGTRAP"
+BLACKWORDS += "SIGTSTP"
+BLACKWORDS += "SIGTTIN"
+BLACKWORDS += "SIGTTOU"
+BLACKWORDS += "SIGURG"
+BLACKWORDS += "SIGVTALRM"
+BLACKWORDS += "SIGXCPU"
+BLACKWORDS += "SIGXFSZ"
+BLACKWORDS += "SIGSTKSZ"
+BLACKWORDS += "stack_t"
+BLACKWORDS += "siginterrupt"
+BLACKWORDS += "threads_scenarii.c"
+
+BLACKWORDS += "ILL_[A-Z]"
+BLACKWORDS += "FPE_[A-Z]"
+BLACKWORDS += "BUS_[A-Z]"
+BLACKWORDS += "TRAP_[A-Z]"
+BLACKWORDS += "SEGV_[A-Z]"
+BLACKWORDS += "POLL_[A-Z]"
+BLACKWORDS += "SA_ONSTACK"
+BLACKWORDS += "MINSIGSTKSZ"
+BLACKWORDS += "FPE_FLTINV"
+
+BLACKSRCS += testfrmw.c
+BLACKSRCS += 7-3-buildonly.c
+BLACKSRCS += 7-4-buildonly.c
+BLACKSRCS += 7-5-buildonly.c
+BLACKSRCS += 11-1-buildonly.c
+BLACKSRCS += 17-1-buildonly.c
+BLACKSRCS += 19-1-buildonly.c
+BLACKSRCS += 21-1-buildonly.c
+BLACKSRCS += 22-31-buildonly.c
+BLACKSRCS += 22-32-buildonly.c
+BLACKSRCS += 25-1-buildonly.c
+BLACKSRCS += 27-1-buildonly.c
+BLACKSRCS += 35-1-buildonly.c
+BLACKSRCS += 35-2-buildonly.c
+
+MAINWORDS += "main("
+
+LTP_ORIGINS := $(shell find $(TESTDIR) -name *.c)
+
+$(foreach word, $(BLACKWORDS), $(eval BLACKLIST+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+$(foreach src, $(BLACKSRCS), $(eval BLACKLIST+=$(filter %$(src),$(LTP_ORIGINS))))
+
+LTP_ORIGINS := $(filter-out $(BLACKLIST), $(LTP_ORIGINS))
+
+$(foreach word, $(MAINWORDS), $(eval LTP_MAINCSRCS+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+
+LTP_CSRCS := $(filter-out $(LTP_MAINCSRCS), $(LTP_ORIGINS))
+
+PROGNAME := $(basename $(shell echo $(LTP_MAINCSRCS) | xargs -n 1 | awk -F "[/]" '{print "ltp_"$$(NF-2)"_"$$(NF-1)"_"$$(NF)}' | sed s/-/_/g))
+MAINSRC = $(LTP_MAINCSRCS)
+PRIORITY = SCHED_PRIORITY_DEFAULT
+STACKSIZE = $(CONFIG_DEFAULT_TASK_STACKSIZE)
+MODULE = $(CONFIG_TESTING_LTP)
+
+CSRCS := $(LTP_CSRCS)
+CFLAGS += -I$(LTP_UNPACK)
+CFLAGS += -I$(TESTDIR)/include
+
+$(LTP_UNPACK):
+ $(Q) echo "git clone $(LTP_URL)"
+ $(Q) git clone $(LTP_URL)
+
+context:: $(LTP_UNPACK)
+
+clean::
+ $(call DELFILE, .built)
+ $(call CLEAN)
Review comment:
> remove,
update to distclean and remove clean
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704324362
I would want to know more about the 20k line patch file before merging this in. It's GPL code in the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-745034765
LGTM, @btashton could you review again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704404617
> > @ttnie is it ready to merge?
>
> @acassis there are few compiling warnings need to resolve before merging. We ares in China Nation Holiday, the progress is a little bit slow.
Hi @xiaoxiang781216 I'm sorry, I forgot about it. When are people coming back? On Thursday?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704357140
> It's 20k lines of GPL we cannot have that in the Apache release bundle. Also it's not clear to me how we would maintain it.
All changes aren't specific to NuttX, @ttnie and @PeterBee97 is preparing to upstream the patch to mainline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] justinmclean commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
justinmclean commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705205518
Here's the main information on GPL (and other Category X) licenses. https://www.apache.org/legal/resolved.html#prohibited
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie closed pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie closed pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton merged pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704996917
>
>
> There are lot of other Apache projects that support being built with non allowed code such as some intel and Nvidia libraries. It is my understanding that the Apache project just still needs to be functional without it which certainly is the case here.
That seems like a reasonable interpretation to me. But it would still be good to have an official ASF position.
Proprietary licenses like Intel and Nvidia are different from GPL in that they don't have the viral properties of GPL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-716288775
> @ttnie why do we need to make all of the functions and variables static here? Seems like we should be able to work around this in the build without having to patch that in?
> Ok, just wanted to see if there was a way to work around it if we face resistance upstream :)
I make sense, the modifications of LTP is plan to added to GPL by our team member. And no need patch at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704363416
> > It's 20k lines of GPL we cannot have that in the Apache release bundle. Also it's not clear to me how we would maintain it.
>
> @btashton all changes aren't specific to NuttX, @ttnie and @PeterBee97 is preparing to upstream the patch to mainline.
Awesome that would be the best. If we hit a roadblock maybe we can consider handling it like we do with the other restricted tools. This is certainly something we want to be able to support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] justinmclean commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
justinmclean commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705201917
Proprietary licenses like some Intel and Nvidia ones are different are in general not compatible with the Apache license as they add restrictions above and beyond what the Apache license allows. If a license add any condition (not just copyleft) then it cannot be included in a release or depended on.If you want an example of where a project can get into trouble look at the issues with MXNet project and it use of Nvidia licensed code. You can find this in the last several Incubator reports https://whimsy.apache.org/board/minutes/Incubator.html. The likely outcome of this is that either Nvidia will change it license or MXNet will no longer be an Apache project.
Category X license dependancies are allowed if the feature is truely optional and the user need to install that themselves. See https://www.apache.org/legal/resolved.html#optional
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-716284666
Ok, just wanted to see if there was a way to work around it if we face resistance upstream :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705206129
> Category X license dependancies are allowed if the feature is truely optional and the user need to install that themselves. See https://www.apache.org/legal/resolved.html#optional
Certainly, this code is _optional_ by that definition. In this case, the NuttX project code would provide the logic to automatically download the code without requiring that the user perform the download. So the use of GPL is completely transparent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-716284206
> @ttnie why do we need to make all of the functions and variables static here? Seems like we should be able to work around this in the build without having to patch that in?
please ignore this PR, we'll apply LTP modifications to GPL not nuttx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704357140
> It's 20k lines of GPL we cannot have that in the Apache release bundle. Also it's not clear to me how we would maintain it.
@btashton all changes aren't specific to NuttX, @ttnie and @PeterBee97 is preparing to upstream the patch to mainline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543022554
##########
File path: testing/ltp/Makefile
##########
@@ -0,0 +1,117 @@
+
+# apps/testing/ltp/ltp/Makefile
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+include $(APPDIR)/Make.defs
+
+LTP_UNPACK = ltp
+LTP_URL = https://github.com/linux-test-project/ltp.git
+
+TESTDIR = $(LTP_UNPACK)/testcases/open_posix_testsuite
+
+ifeq ($(CONFIG_FS_AIO),)
+BLACKWORDS += "aio.h"
+BLACKWORDS += "SIGPOLL"
+endif
+BLACKWORDS += "affinity.h"
+BLACKWORDS += "langinfo.h"
+BLACKWORDS += "ucontext.h"
+BLACKWORDS += "noatime.h"
+BLACKWORDS += "CLOCK_PROCESS_CPUTIME_ID"
+BLACKWORDS += "CLOCK_THREAD_CPUTIME_ID"
+BLACKWORDS += "fork()"
+BLACKWORDS += "pthread_attr_setscope"
+BLACKWORDS += "RLIMIT_MEMLOCK"
+BLACKWORDS += "PTHREAD_SCOPE_PROCESS"
+BLACKWORDS += "SIGABRT"
+BLACKWORDS += "SIGBUS"
+BLACKWORDS += "SIGFPE"
+BLACKWORDS += "SIGHUP"
+BLACKWORDS += "SIGILL"
+BLACKWORDS += "SIGPROF"
+BLACKWORDS += "SIGSEGV"
+BLACKWORDS += "SIGSYS"
+BLACKWORDS += "SIGTRAP"
+BLACKWORDS += "SIGTSTP"
+BLACKWORDS += "SIGTTIN"
+BLACKWORDS += "SIGTTOU"
+BLACKWORDS += "SIGURG"
+BLACKWORDS += "SIGVTALRM"
+BLACKWORDS += "SIGXCPU"
+BLACKWORDS += "SIGXFSZ"
+BLACKWORDS += "SIGSTKSZ"
+BLACKWORDS += "stack_t"
+BLACKWORDS += "siginterrupt"
+BLACKWORDS += "threads_scenarii.c"
+
+BLACKWORDS += "ILL_[A-Z]"
+BLACKWORDS += "FPE_[A-Z]"
+BLACKWORDS += "BUS_[A-Z]"
+BLACKWORDS += "TRAP_[A-Z]"
+BLACKWORDS += "SEGV_[A-Z]"
+BLACKWORDS += "POLL_[A-Z]"
+BLACKWORDS += "SA_ONSTACK"
+BLACKWORDS += "MINSIGSTKSZ"
+BLACKWORDS += "FPE_FLTINV"
+
+BLACKSRCS += testfrmw.c
+BLACKSRCS += 7-3-buildonly.c
+BLACKSRCS += 7-4-buildonly.c
+BLACKSRCS += 7-5-buildonly.c
+BLACKSRCS += 11-1-buildonly.c
+BLACKSRCS += 17-1-buildonly.c
+BLACKSRCS += 19-1-buildonly.c
+BLACKSRCS += 21-1-buildonly.c
+BLACKSRCS += 22-31-buildonly.c
+BLACKSRCS += 22-32-buildonly.c
+BLACKSRCS += 25-1-buildonly.c
+BLACKSRCS += 27-1-buildonly.c
+BLACKSRCS += 35-1-buildonly.c
+BLACKSRCS += 35-2-buildonly.c
+
+MAINWORDS += "main("
+
+LTP_ORIGINS := $(shell find $(TESTDIR) -name *.c)
+
+$(foreach word, $(BLACKWORDS), $(eval BLACKLIST+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+$(foreach src, $(BLACKSRCS), $(eval BLACKLIST+=$(filter %$(src),$(LTP_ORIGINS))))
+
+LTP_ORIGINS := $(filter-out $(BLACKLIST), $(LTP_ORIGINS))
+
+$(foreach word, $(MAINWORDS), $(eval LTP_MAINCSRCS+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+
+LTP_CSRCS := $(filter-out $(LTP_MAINCSRCS), $(LTP_ORIGINS))
+
+PROGNAME := $(basename $(shell echo $(LTP_MAINCSRCS) | xargs -n 1 | awk -F "[/]" '{print "ltp_"$$(NF-2)"_"$$(NF-1)"_"$$(NF)}' | sed s/-/_/g))
+MAINSRC = $(LTP_MAINCSRCS)
+PRIORITY = SCHED_PRIORITY_DEFAULT
+STACKSIZE = $(CONFIG_DEFAULT_TASK_STACKSIZE)
+MODULE = $(CONFIG_TESTING_LTP)
+
+CSRCS := $(LTP_CSRCS)
+CFLAGS += -I$(LTP_UNPACK)
+CFLAGS += -I$(TESTDIR)/include
+
+$(LTP_UNPACK):
+ $(Q) echo "git clone $(LTP_URL)"
+ $(Q) git clone $(LTP_URL)
+
+context:: $(LTP_UNPACK)
+
+clean::
+ $(call DELFILE, .built)
Review comment:
remove since .built isn't generated anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r496561199
##########
File path: testing/ltp/Kconfig
##########
@@ -0,0 +1,10 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config TESTING_CXXTEST
Review comment:
@xiaoxiang781216 update done.
##########
File path: testing/ltp/Make.defs
##########
@@ -0,0 +1,39 @@
+############################################################################
+# apps/testing/Make.defs
Review comment:
@xiaoxiang781216 update done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-716282775
@ttnie why do we need to make all of the functions and variables static here? Seems like we should be able to work around this in the build without having to patch that in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] justinmclean commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
justinmclean commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-705204694
Now in general using non compatible licenses for testing is fine as no incapable nothing ends up in the final source or binary release. e.g JUnit But it seem like this issue may be more similar with one of the MXNet issue it that GPL licensed code ends up in the binary. Is this correct? If so there is a dependency on GPL and would not be allowed unless it's an optional feature that is not built by default and the user is made aware of the licensing implication if they do enable it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] ttnie commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
ttnie commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r543016703
##########
File path: testing/ltp/Makefile
##########
@@ -0,0 +1,113 @@
+
+# apps/testing/ltp/ltp/Makefile
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+include $(APPDIR)/Make.defs
+
+LTP_UNPACK = ltp
+LTP_URL = https://github.com/linux-test-project/ltp.git
+
+TESTDIR = $(LTP_UNPACK)/testcases/open_posix_testsuite
+
+ifeq ($(CONFIG_FS_AIO),)
+BLACKWORDS += "aio.h"
+BLACKWORDS += "SIGPOLL"
+endif
+BLACKWORDS += "affinity.h"
+BLACKWORDS += "langinfo.h"
+BLACKWORDS += "ucontext.h"
+BLACKWORDS += "noatime.h"
+BLACKWORDS += "CLOCK_PROCESS_CPUTIME_ID"
+BLACKWORDS += "CLOCK_THREAD_CPUTIME_ID"
+BLACKWORDS += "fork()"
+BLACKWORDS += "pthread_attr_setscope"
+BLACKWORDS += "RLIMIT_MEMLOCK"
+BLACKWORDS += "PTHREAD_SCOPE_PROCESS"
+BLACKWORDS += "SIGABRT"
+BLACKWORDS += "SIGBUS"
+BLACKWORDS += "SIGFPE"
+BLACKWORDS += "SIGHUP"
+BLACKWORDS += "SIGILL"
+BLACKWORDS += "SIGPROF"
+BLACKWORDS += "SIGSEGV"
+BLACKWORDS += "SIGSYS"
+BLACKWORDS += "SIGTRAP"
+BLACKWORDS += "SIGTSTP"
+BLACKWORDS += "SIGTTIN"
+BLACKWORDS += "SIGTTOU"
+BLACKWORDS += "SIGURG"
+BLACKWORDS += "SIGVTALRM"
+BLACKWORDS += "SIGXCPU"
+BLACKWORDS += "SIGXFSZ"
+BLACKWORDS += "SIGSTKSZ"
+BLACKWORDS += "stack_t"
+BLACKWORDS += "siginterrupt"
+BLACKWORDS += "threads_scenarii.c"
+
+BLACKWORDS += "ILL_[A-Z]"
+BLACKWORDS += "FPE_[A-Z]"
+BLACKWORDS += "BUS_[A-Z]"
+BLACKWORDS += "TRAP_[A-Z]"
+BLACKWORDS += "SEGV_[A-Z]"
+BLACKWORDS += "POLL_[A-Z]"
+BLACKWORDS += "SA_ONSTACK"
+BLACKWORDS += "MINSIGSTKSZ"
+BLACKWORDS += "FPE_FLTINV"
+
+BLACKSRCS += testfrmw.c
+BLACKSRCS += 7-3-buildonly.c
+BLACKSRCS += 7-4-buildonly.c
+BLACKSRCS += 7-5-buildonly.c
+BLACKSRCS += 11-1-buildonly.c
+BLACKSRCS += 17-1-buildonly.c
+BLACKSRCS += 19-1-buildonly.c
+BLACKSRCS += 21-1-buildonly.c
+BLACKSRCS += 22-31-buildonly.c
+BLACKSRCS += 22-32-buildonly.c
+BLACKSRCS += 25-1-buildonly.c
+BLACKSRCS += 27-1-buildonly.c
+BLACKSRCS += 35-1-buildonly.c
+BLACKSRCS += 35-2-buildonly.c
+
+MAINWORDS += "main("
+
+LTP_ORIGINS := $(shell find $(TESTDIR) -name *.c)
+
+$(foreach word, $(BLACKWORDS), $(eval BLACKLIST+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+$(foreach src, $(BLACKSRCS), $(eval BLACKLIST+=$(filter %$(src),$(LTP_ORIGINS))))
+
+LTP_ORIGINS := $(filter-out $(BLACKLIST), $(LTP_ORIGINS))
+
+$(foreach word, $(MAINWORDS), $(eval LTP_MAINCSRCS+=$(shell grep -lr $(word) $(LTP_ORIGINS))))
+
+LTP_CSRCS := $(filter-out $(LTP_MAINCSRCS), $(LTP_ORIGINS))
+
+PROGNAME := $(basename $(shell echo $(LTP_MAINCSRCS) | xargs -n 1 | awk -F "[/]" '{print "ltp_"$$(NF-2)"_"$$(NF-1)"_"$$(NF)}' | sed s/-/_/g))
+MAINSRC = $(LTP_MAINCSRCS)
+PRIORITY = SCHED_PRIORITY_DEFAULT
+STACKSIZE = $(CONFIG_DEFAULT_TASK_STACKSIZE)
+MODULE = $(CONFIG_TESTING_LTP)
+
+CSRCS := $(LTP_CSRCS)
+CFLAGS += -I$(LTP_UNPACK)
+CFLAGS += -I$(TESTDIR)/include
+
+$(LTP_UNPACK):
+ $(Q) echo "git clone $(LTP_URL)"
+ $(Q) git clone $(LTP_URL)
+
+context:: $(LTP_UNPACK)
+
+
Review comment:
> need add distclean to keep git status clear.
add clean part to makefile, pls review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#discussion_r496474620
##########
File path: testing/ltp/Make.defs
##########
@@ -0,0 +1,39 @@
+############################################################################
+# apps/testing/Make.defs
Review comment:
replace the copyright
##########
File path: testing/ltp/Kconfig
##########
@@ -0,0 +1,10 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config TESTING_CXXTEST
Review comment:
change the name of option
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-716323484
> @ttnie why do we need to make all of the functions and variables static here? Seems like we should be able to work around this in the build without having to patch that in?
In Linux, each test case build into a separated ELF binary, but NuttX build all soruces into one big image(execpt we enable ELF binfmt). So the linker complain the duplicated symbols on NuttX. But anyway, it's always a good egnineering practice to limit the symbol scope as small as possible even it isn't so critical on Linux.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #410: Add LTP support
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #410:
URL: https://github.com/apache/incubator-nuttx-apps/pull/410#issuecomment-704346428
It's 20k lines of GPL we cannot have that in the Apache release bundle. Also it's not clear to me how we would maintain it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org