[GitHub] spark pull request #21185: [SPARK-23894][CORE][SQL] Defensively clear Active...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21185#discussion_r185612118
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -229,6 +229,23 @@ private[spark] class Executor(
         ManagementFactory.getGarbageCollectorMXBeans.asScala.map(_.getCollectionTime).sum
       }
     
    +  /**
    +   * Only in local mode, we have to prevent the driver from setting the active SparkSession
    +   * in the executor threads.  See SPARK-23894.
    +   */
    +  private lazy val clearActiveSparkSessionMethod = if (Utils.isLocalMaster(conf)) {
    --- End diff --
    
    Do we still need to call this if we can resolve the root cause in https://github.com/apache/spark/pull/21190, and issue an error promptly like what you said in https://github.com/apache/spark/pull/21185#issuecomment-385996077?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org