[GitHub] [spark] grundprinzip commented on a diff in pull request #38485: [SPARK-41001] [CONNECT] [PYTHON] Implementing Connection String for Python Client

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #38485:
URL: https://github.com/apache/spark/pull/38485#discussion_r1012594975


##########
python/pyspark/sql/connect/client.py:
##########
@@ -104,11 +224,13 @@ def fromProto(cls, pb: typing.Any) -> "AnalyzeResult":
 class RemoteSparkSession(object):
     """Conceptually the remote spark session that communicates with the server"""
 
-    def __init__(self, user_id: str, host: Optional[str] = None, port: int = 15002):
-        self._host = "localhost" if host is None else host
-        self._port = port
+    def __init__(self, user_id: str, connection_string: str = "sc://localhost"):

Review Comment:
   I'm not sure I understand, this is the constructor though? Or do you mean the argument names?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org