[GitHub] [incubator-druid] himanshug commented on a change in pull request #7588: multi-value string column support for expressions

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #7588: multi-value string column support for expressions
URL: https://github.com/apache/incubator-druid/pull/7588#discussion_r288263051
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/virtual/ExpressionColumnValueSelector.java
 ##########
 @@ -29,8 +29,8 @@
 
 public class ExpressionColumnValueSelector implements ColumnValueSelector<ExprEval>
 {
-  private final Expr.ObjectBinding bindings;
-  private final Expr expression;
+  final Expr.ObjectBinding bindings;
 
 Review comment:
   ```suggestion
     protected final Expr.ObjectBinding bindings;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org