[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11237: Fix aws token caching

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #11237:
URL: https://github.com/apache/pulsar/pull/11237#discussion_r684528882



##########
File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java
##########
@@ -279,47 +279,47 @@ public ProviderMetadata getProviderMetadata() {
     };
 
     static final CredentialBuilder AWS_CREDENTIAL_BUILDER = (TieredStorageConfiguration config) -> {
-        if (config.getCredentials() == null) {
-            final AWSCredentialsProvider authChain;
-            try {
-                if (Strings.isNullOrEmpty(config.getConfigProperty(S3_ROLE_FIELD))) {
-                    authChain = DefaultAWSCredentialsProviderChain.getInstance();
+//        if (config.getCredentials() == null) {

Review comment:
       Just a comment on style here: in a future PR, I recommend removing this line. Its record will be stored in git history, and there isn't any need to keep it for future reference.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org