You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2025/11/01 18:52:01 UTC
[PR] Remove unused includes [couchdb]
nickva opened a new pull request, #5729:
URL: https://github.com/apache/couchdb/pull/5729
Figured these out by playing with `elp lint`
`% elp lint --read-config`
Using `.elp_lint.toml`
```
enabled_lints = ['W0020']
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused includes [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #5729:
URL: https://github.com/apache/couchdb/pull/5729#discussion_r2483854712
##########
src/chttpd/src/chttpd_stats.erl:
##########
@@ -13,7 +13,6 @@
-module(chttpd_stats).
% for the stacktrace macro only so far
--include_lib("couch/include/couch_db.hrl").
Review Comment:
Updated.
##########
src/ddoc_cache/src/ddoc_cache_entry.erl:
##########
@@ -14,7 +14,6 @@
-behaviour(gen_server).
% for the stacktrace macro only so far
--include_lib("couch/include/couch_db.hrl").
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused includes [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #5729:
URL: https://github.com/apache/couchdb/pull/5729#discussion_r2483853123
##########
src/chttpd/src/chttpd_stats.erl:
##########
@@ -13,7 +13,6 @@
-module(chttpd_stats).
% for the stacktrace macro only so far
--include_lib("couch/include/couch_db.hrl").
Review Comment:
Thank you, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused includes [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #5729:
URL: https://github.com/apache/couchdb/pull/5729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused includes [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #5729:
URL: https://github.com/apache/couchdb/pull/5729#issuecomment-3476746424
> Would such checks be useful in the CI?
Yeah, that would be nice. We'd have to install elp and then have a way to handle exceptions. Some dependencies have issues so we'd have to account for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused includes [couchdb]
Posted by "jaydoane (via GitHub)" <gi...@apache.org>.
jaydoane commented on code in PR #5729:
URL: https://github.com/apache/couchdb/pull/5729#discussion_r2483852143
##########
src/ddoc_cache/src/ddoc_cache_entry.erl:
##########
@@ -14,7 +14,6 @@
-behaviour(gen_server).
% for the stacktrace macro only so far
--include_lib("couch/include/couch_db.hrl").
Review Comment:
And here too?
##########
src/chttpd/src/chttpd_stats.erl:
##########
@@ -13,7 +13,6 @@
-module(chttpd_stats).
% for the stacktrace macro only so far
--include_lib("couch/include/couch_db.hrl").
Review Comment:
Maybe also delete comment above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused includes [couchdb]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #5729:
URL: https://github.com/apache/couchdb/pull/5729#discussion_r2483852588
##########
src/ddoc_cache/src/ddoc_cache_entry.erl:
##########
@@ -14,7 +14,6 @@
-behaviour(gen_server).
% for the stacktrace macro only so far
--include_lib("couch/include/couch_db.hrl").
Review Comment:
Oops, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unused includes [couchdb]
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on PR #5729:
URL: https://github.com/apache/couchdb/pull/5729#issuecomment-3476740821
Would such checks be useful in the CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org