[shardingsphere] branch master updated: Refactor InventoryIncrementalJobAPI (#25768)

[pa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 01665addbbf Refactor InventoryIncrementalJobAPI (#25768)
01665addbbf is described below

commit 01665addbbf0deacd76f873eafd323d0505606bf
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Thu May 18 22:37:41 2023 +0800

    Refactor InventoryIncrementalJobAPI (#25768)
---
 .../data/pipeline/cdc/api/impl/CDCJobAPI.java      |  4 ++--
 .../core/api/InventoryIncrementalJobAPI.java       | 24 +++++++++++-----------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/api/impl/CDCJobAPI.java b/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/api/impl/CDCJobAPI.java
index 97931179bdf..7ed1eb70836 100644
--- a/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/api/impl/CDCJobAPI.java
+++ b/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/api/impl/CDCJobAPI.java
@@ -342,7 +342,7 @@ public final class CDCJobAPI extends AbstractInventoryIncrementalJobAPIImpl {
     }
     
     @Override
-    public void rollback(final String jobId) throws SQLException {
+    public void commit(final String jobId) {
         CDCJobConfiguration jobConfig = getJobConfiguration(jobId);
         if (CDCSinkType.SOCKET == jobConfig.getSinkConfig().getSinkType()) {
             PipelineJobCenter.stop(jobId);
@@ -353,7 +353,7 @@ public final class CDCJobAPI extends AbstractInventoryIncrementalJobAPIImpl {
     }
     
     @Override
-    public void commit(final String jobId) {
+    public void rollback(final String jobId) throws SQLException {
         CDCJobConfiguration jobConfig = getJobConfiguration(jobId);
         if (CDCSinkType.SOCKET == jobConfig.getSinkConfig().getSinkType()) {
             PipelineJobCenter.stop(jobId);
diff --git a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/InventoryIncrementalJobAPI.java b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/InventoryIncrementalJobAPI.java
index 420ad67ddf7..2e4afca0529 100644
--- a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/InventoryIncrementalJobAPI.java
+++ b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/InventoryIncrementalJobAPI.java
@@ -59,15 +59,15 @@ public interface InventoryIncrementalJobAPI extends PipelineJobAPI {
     /**
      * Persist job offset info.
      *
-     * @param jobId job id
-     * @param jobOffsetInfo job offset info.
+     * @param jobId job ID
+     * @param jobOffsetInfo job offset info
      */
     void persistJobOffsetInfo(String jobId, JobOffsetInfo jobOffsetInfo);
     
     /**
      * Get job offset info.
      *
-     * @param jobId job id
+     * @param jobId job ID
      * @return job offset progress
      */
     JobOffsetInfo getJobOffsetInfo(String jobId);
@@ -86,7 +86,7 @@ public interface InventoryIncrementalJobAPI extends PipelineJobAPI {
     /**
      * Get job infos.
      *
-     * @param jobId job id
+     * @param jobId job ID
      * @return job item infos
      */
     List<InventoryIncrementalJobItemInfo> getJobItemInfos(String jobId);
@@ -122,24 +122,24 @@ public interface InventoryIncrementalJobAPI extends PipelineJobAPI {
     /**
      * Aggregate data consistency check results.
      *
-     * @param jobId job id
+     * @param jobId job ID
      * @param checkResults check results
      * @return check success or not
      */
     boolean aggregateDataConsistencyCheckResults(String jobId, Map<String, DataConsistencyCheckResult> checkResults);
     
     /**
-     * Rollback pipeline job.
+     * Commit pipeline job.
      *
-     * @param jobId job id
-     * @throws SQLException when rollback underlying database data
+     * @param jobId job ID
      */
-    void rollback(String jobId) throws SQLException;
+    void commit(String jobId);
     
     /**
-     * Commit pipeline job.
+     * Rollback pipeline job.
      *
-     * @param jobId job id
+     * @param jobId job ID
+     * @throws SQLException when rollback underlying database data
      */
-    void commit(String jobId);
+    void rollback(String jobId) throws SQLException;
 }