You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/04/03 09:45:42 UTC
Review Request 58142: Click of "NEW JOB" button doesn't create new
worksheet tab
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58142/
-----------------------------------------------------------
Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20658
https://issues.apache.org/jira/browse/AMBARI-20658
Repository: ambari
Description
-------
We are now checking the count of worksheets present and apeending it to the worksheet name
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js b48b8df
contrib/views/hive20/src/main/resources/ui/app/templates/components/top-application-bar.hbs f163dca
Diff: https://reviews.apache.org/r/58142/diff/1/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 58142: Click of "NEW JOB" button doesn't create new
worksheet tab
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58142/#review170858
-----------------------------------------------------------
Ship it!
Ship It!
contrib/views/hive20/src/main/resources/ui/app/templates/components/top-application-bar.hbs
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/58142/#comment243720>
avoid whitespace-only changes in future patches.
- Nitiraj Rathore
On April 3, 2017, 9:45 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58142/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 9:45 a.m.)
>
>
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20658
> https://issues.apache.org/jira/browse/AMBARI-20658
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We are now checking the count of worksheets present and apeending it to the worksheet name
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js b48b8df
> contrib/views/hive20/src/main/resources/ui/app/templates/components/top-application-bar.hbs f163dca
>
>
> Diff: https://reviews.apache.org/r/58142/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58142: Click of "NEW JOB" button doesn't create new
worksheet tab
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58142/#review170844
-----------------------------------------------------------
Ship it!
Ship It!
- Padma Priya N
On April 3, 2017, 9:45 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58142/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 9:45 a.m.)
>
>
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20658
> https://issues.apache.org/jira/browse/AMBARI-20658
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We are now checking the count of worksheets present and apeending it to the worksheet name
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js b48b8df
> contrib/views/hive20/src/main/resources/ui/app/templates/components/top-application-bar.hbs f163dca
>
>
> Diff: https://reviews.apache.org/r/58142/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>