[GitHub] [incubator-seatunnel] yx91490 edited a comment on pull request #1236: [Bug] [config] Fix "Can only specify option -i once" in command line args parser

[GitBox <gi...@apache.org>]

yx91490 edited a comment on pull request #1236:
URL: https://github.com/apache/incubator-seatunnel/pull/1236#issuecomment-1041584786


   > > > Hi @yx91490, we nerver use `variables` in the main logic.
   > > 
   > > 
   > > I think this quietly a bug, isn't it? this pr is the smallest code modification to fix this bug, which is the same logic as original. If you think the original code's logical had problems, maybe we can discuss in another issue.
   > 
   > As @leo65535 said, the `variables` is never used, so it might be better to remove it.
   
   remove it is not a easy and the best way to fix this, because in start-seatunnel-spark.sh script, all arguments will be passed to java code, and finally be parsed by jcommander, but currently jcommander will throw exception if input an unknown parameter. whether modify start script or jcomander will pay much effort to ensure compatibility and not to introduce new bugs, which is poles apart with the issue's original intention: just fix an obviously bug that was introduced by a unequal code translation. 
   Hope you can understand, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org