You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by ch...@apache.org on 2006/10/24 09:03:12 UTC

svn commit: r467260 - in /webservices/axis2/branches/java/1_1/modules: kernel/src/org/apache/axis2/transport/http/AdminAgent.java webapp/ServiceParaEdit.jsp

Author: chamil
Date: Tue Oct 24 00:03:12 2006
New Revision: 467260

URL: http://svn.apache.org/viewvc?view=rev&rev=467260
Log:
Changes to show the saved successfully message on the same page and to show a massage when trying to edit parameters of an inactive service. [Before it was giving an error.]

Modified:
    webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java
    webservices/axis2/branches/java/1_1/modules/webapp/ServiceParaEdit.jsp

Modified: webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java?view=diff&rev=467260&r1=467259&r2=467260
==============================================================================
--- webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java (original)
+++ webservices/axis2/branches/java/1_1/modules/kernel/src/org/apache/axis2/transport/http/AdminAgent.java Tue Oct 24 00:03:12 2006
@@ -189,53 +189,51 @@
         }
     }
 
-    protected void processEditServicePara(HttpServletRequest req, HttpServletResponse res) throws IOException, ServletException {
-        if (req.getParameter("changePara") != null) {
-            String serviceName = req.getParameter("axisService");
-            AxisService service = configContext.getAxisConfiguration().getService(serviceName);
-
-            if (service != null) {
-                ArrayList service_para = service.getParameters();
-
-                for (int i = 0; i < service_para.size(); i++) {
-                    Parameter parameter = (Parameter) service_para.get(i);
-                    String para = req.getParameter(serviceName + "_" + parameter.getName());
-
-                    service.addParameter(new Parameter(parameter.getName(), para));
-                }
-
-                for (Iterator iterator = service.getOperations(); iterator.hasNext();) {
-                    AxisOperation axisOperation = (AxisOperation) iterator.next();
-                    String op_name = axisOperation.getName().getLocalPart();
-                    ArrayList operation_para = axisOperation.getParameters();
-
-                    for (int i = 0; i < operation_para.size(); i++) {
-                        Parameter parameter = (Parameter) operation_para.get(i);
-                        String para = req.getParameter(op_name + "_" + parameter.getName());
-
-                        axisOperation.addParameter(new Parameter(parameter.getName(), para));
-                    }
-                }
-            }
-
-            OutputStream out = res.getOutputStream();
-            res.setContentType("text/html");
-            out.write(getBasicHTML("Parameters Changed Successfully").getBytes());
-            out.flush();
-            out.close();
-            req.getSession().removeAttribute(Constants.SERVICE);
-
-            return;
-        } else {
-            String service = req.getParameter("axisService");
-
-            if (service != null) {
-                req.getSession().setAttribute(
-                        Constants.SERVICE, configContext.getAxisConfiguration().getService(service));
-            }
-        }
-
-        renderView(SERVICE_PARA_EDIT_JSP_NAME, req, res);
+    protected void processEditServicePara(HttpServletRequest req, HttpServletResponse res)
+    throws IOException, ServletException {
+    	String serviceName = req.getParameter("axisService");
+    	if (req.getParameter("changePara") != null) {
+    		AxisService service = configContext.getAxisConfiguration().getService(serviceName);
+    		if (service != null) {
+    			ArrayList service_para = service.getParameters();
+
+    			for (int i = 0; i < service_para.size(); i++) {
+    				Parameter parameter = (Parameter) service_para.get(i);
+    				String para = req.getParameter(serviceName + "_" + parameter.getName());
+    				service.addParameter(new Parameter(parameter.getName(), para));
+    			}
+
+    			for (Iterator iterator = service.getOperations(); iterator.hasNext();) {
+    				AxisOperation axisOperation = (AxisOperation) iterator.next();
+    				String op_name = axisOperation.getName().getLocalPart();
+    				ArrayList operation_para = axisOperation.getParameters();
+
+    				for (int i = 0; i < operation_para.size(); i++) {
+    					Parameter parameter = (Parameter) operation_para.get(i);
+    					String para = req.getParameter(op_name + "_" + parameter.getName());
+
+    					axisOperation.addParameter(new Parameter(parameter.getName(), para));
+    				}
+    			}
+    		}
+    		res.setContentType("text/html");
+    		req.setAttribute("status", "Parameters Changed Successfully.");
+    		req.getSession().removeAttribute(Constants.SERVICE);
+    	} else {
+    		AxisService serviceTemp =
+    			configContext.getAxisConfiguration().getServiceForActivation(serviceName);
+    		if (serviceTemp.isActive()) {
+
+    			if (serviceName != null) {
+    				req.getSession().setAttribute(Constants.SERVICE,
+    						configContext.getAxisConfiguration().getService(serviceName));
+    			}
+    		} else {
+    			req.setAttribute("status", "Service " + serviceName + " is not an active service" +
+    			". \n Only parameters of active services can be edited.");
+    		}
+    	}
+    	renderView(SERVICE_PARA_EDIT_JSP_NAME, req, res);
     }
 
     private String getBasicHTML(String s) {

Modified: webservices/axis2/branches/java/1_1/modules/webapp/ServiceParaEdit.jsp
URL: http://svn.apache.org/viewvc/webservices/axis2/branches/java/1_1/modules/webapp/ServiceParaEdit.jsp?view=diff&rev=467260&r1=467259&r2=467260
==============================================================================
--- webservices/axis2/branches/java/1_1/modules/webapp/ServiceParaEdit.jsp (original)
+++ webservices/axis2/branches/java/1_1/modules/webapp/ServiceParaEdit.jsp Tue Oct 24 00:03:12 2006
@@ -105,6 +105,10 @@
                </tr>
                  </table>
                  <%
+             } else {
+            	%>
+            	<p><%=request.getAttribute("status")%></p>
+            	<%
              }
 
        %>



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org