You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by jgrzebyta <gi...@git.apache.org> on 2017/10/23 14:02:31 UTC

[GitHub] any23 pull request #45: Any23-312 simplify yaml parsing outcome

GitHub user jgrzebyta opened a pull request:

    https://github.com/apache/any23/pull/45

    Any23-312 simplify yaml parsing outcome

    - Simplify graph
    - In case if a triple is not completed (missing object) than it is not created (previous time RDF:NIL was added as object). Still predicates characteristic (`[] rdf:type rdf:predicate ; rdfs:label ?name`) is added to final graph.
    - Make subgraph blank nodes based.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jgrzebyta/any23 ANY23-312

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/any23/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #45
    
----
commit af0a7e154e36564b315c253089900968d8df0a26
Author: Jacek Grzebyta <gr...@gmail.com>
Date:   2017-10-17T16:06:44Z

    Ref ANY23-312
    
    - update example file
    - update unit test
    Signed-off-by:Jacek Grzebyta <gr...@gmail.com>

commit 783434d55648990469f7bf958d687c98796adfad
Author: Jacek Grzebyta <gr...@gmail.com>
Date:   2017-10-17T16:22:53Z

    Ref ANY23-312
    
    - buildNode method returns Optional wrapper
    
    
    Signed-off-by:Jacek Grzebyta <gr...@gmail.com>

commit c7dd09e22810763f75131e38fea66475f39573c2
Author: Jacek Grzebyta <gr...@gmail.com>
Date:   2017-10-18T17:50:30Z

    Update RDFUtils
    
    - remove some converters to util class
    
    
    Signed-off-by:Jacek Grzebyta <gr...@gmail.com>

commit f787e42e0357949b44408645b4546cd447242862
Author: Jacek Grzebyta <gr...@gmail.com>
Date:   2017-10-20T16:41:40Z

    Create ElementProcessor
    
    - add unit test
    
    Signed-off-by: Jacek Grzebyta <gr...@gmail.com>

commit 9f0cb636d51fee439310b1180685f48402431516
Author: Jacek Grzebyta <gr...@gmail.com>
Date:   2017-10-21T09:27:06Z

    Create ElementProcessor - RDF-izer
    
    - Add RDF-iser based on types
    - add unit tests
    
    Signed-off-by: Jacek Grzebyta <gr...@gmail.com>

commit f1b26dfdc634c7e70e762319b60c968935a5be93
Author: Jacek Grzebyta <gr...@gmail.com>
Date:   2017-10-23T11:36:04Z

    Update ElementProcessor - RDF-izer
    
    - make processor singleton
    - update unit tests
    Signed-off-by:Jacek Grzebyta <gr...@gmail.com>

commit 657912b3aa22b1f46918fb39f2dc1a0a459303d8
Author: Jacek Grzebyta <gr...@gmail.com>
Date:   2017-10-23T11:40:21Z

    Update YamlExtractor
    
    - update unit tests
    - add test to simple text file
    Signed-off-by:Jacek Grzebyta <gr...@gmail.com>

commit 246af9b3d038046579add68b23598f9d9f8be14b
Author: Jacek Grzebyta <gr...@gmail.com>
Date:   2017-10-23T13:55:55Z

    Ref ANY23-312
    
    - ElementProcessor: fix issue in map validation
                        returns always empty model if parsed to literal
    - YamlExtractor: fix issue with yaml containing only literals
    - update unit tests
    
    
    Signed-off-by:Jacek Grzebyta <gr...@gmail.com>

----


---

[GitHub] any23 pull request #45: Any23-312 simplify yaml parsing outcome

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/any23/pull/45#discussion_r151035471
  
    --- Diff: core/src/main/java/org/apache/any23/extractor/yaml/ElementsProcessor.java ---
    @@ -0,0 +1,201 @@
    +/*
    + * Copyright 2017 The Apache Software Foundation.
    --- End diff --
    
    No need to include Copyright in any new files. These quickly become out-of-date from year to year. We just put a generic license header and then in NOTICE include the Copyright year. Can you please remove the Copyright? Thanks @jgrzebyta 


---

[GitHub] any23 issue #45: Any23-312 simplify yaml parsing outcome

Posted by jgrzebyta <gi...@git.apache.org>.
Github user jgrzebyta commented on the issue:

    https://github.com/apache/any23/pull/45
  
    @lewismc thanks for pointing the copyright issue because I found that in several files.
    
    I will add unit tests for sparql example. But I am pro `rdf:List` because it is parsable by `org.eclipse.rdf4j.model.util.RDFCollections` into java collection.


---

[GitHub] any23 issue #45: Any23-312 simplify yaml parsing outcome

Posted by jgrzebyta <gi...@git.apache.org>.
Github user jgrzebyta commented on the issue:

    https://github.com/apache/any23/pull/45
  
    Guys!  I am still not convinced that `rdf:List` is a good choice for RDF-ised a list in yaml. Manipulation on that, without loosing order, with `sparql` query is challenging I would say.


---

Re: [GitHub] any23 issue #45: Any23-312 simplify yaml parsing outcome

Posted by Jacek Grzebyta <gr...@gmail.com>.
Hi,

Not yet plz. I am building in parallel in separate project a way of reusing
the outcome raw graph.

Regards,
Jacek

On 2 Dec 2017 4:48 p.m., "lewismc" <gi...@git.apache.org> wrote:

> Github user lewismc commented on the issue:
>
>     https://github.com/apache/any23/pull/45
>
>     Hi @jgrzebyta I pulled the code and tested it... all looks good and
> test successfully. I think the additions here make good improvements. I am
> +1 to merge.
>
>
> ---
>

[GitHub] any23 issue #45: Any23-312 simplify yaml parsing outcome

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/45
  
    Hi @jgrzebyta I pulled the code and tested it... all looks good and test successfully. I think the additions here make good improvements. I am +1 to merge.


---

[GitHub] any23 issue #45: Any23-312 simplify yaml parsing outcome

Posted by jgrzebyta <gi...@git.apache.org>.
Github user jgrzebyta commented on the issue:

    https://github.com/apache/any23/pull/45
  
    @lewismc OK. Thanks. First I need to check if the RDF graph is parsable to any final graph.


---

[GitHub] any23 pull request #45: Any23-312 simplify yaml parsing outcome

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/any23/pull/45


---

[GitHub] any23 issue #45: Any23-312 simplify yaml parsing outcome

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/any23/pull/45
  
    @jgrzebyta I am not sure about the ```ref:List``` either. Do you have examples of 
     * an rdf:List, and
     * a SPARQL query which may loose order
    ?


---