You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/19 04:05:56 UTC

[GitHub] [pulsar-client-go] nodece commented on a diff in pull request #913: [Issue 801] Properly apply the back-off policy

nodece commented on code in PR #913:
URL: https://github.com/apache/pulsar-client-go/pull/913#discussion_r1051774588


##########
pulsar/consumer_impl.go:
##########
@@ -535,7 +535,7 @@ func (c *consumer) Nack(msg Message) {
 		}
 
 		if mid.consumer != nil {
-			mid.consumer.NackID(msg.ID())
+			mid.consumer.NackMsg(msg)

Review Comment:
   I suggest you fix the `func (t *negativeAcksTracker) Add(msgID messageID)`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org