You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/17 21:00:06 UTC

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #7234: Adding permission for can_only_access_owned_queries

john-bodley commented on a change in pull request #7234: Adding permission for can_only_access_owned_queries
URL: https://github.com/apache/incubator-superset/pull/7234#discussion_r276431277
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -82,7 +83,7 @@
     'The access requests seem to have been deleted')
 USER_MISSING_ERR = __('The user seems to have been deleted')
 
-FORM_DATA_KEY_BLACKLIST = []
+FORM_DATA_KEY_BLACKLIST = []  # type: List[str]
 
 Review comment:
   You can defined this as:
   ```
   FORM_DATA_KEY_BLACKLIST: List[str] = []
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org