You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2016/12/01 00:56:59 UTC

[jira] [Commented] (HBASE-17210) Set timeout on trying rowlock according to client's RPC timeout

    [ https://issues.apache.org/jira/browse/HBASE-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710399#comment-15710399 ] 

Ted Yu commented on HBASE-17210:
--------------------------------

{code}
5343	      if (call != null && call.getDeadline() < Long.MAX_VALUE) {
5344	        timeout = (int)(call.getDeadline() - System.currentTimeMillis());
{code}
Should timeout be set to rowLockWaitDuration if (call.getDeadline() - System.currentTimeMillis()) <= 0 ?

Please use EnvironmentEdgeManager.currentTime()

> Set timeout on trying rowlock according to client's RPC timeout
> ---------------------------------------------------------------
>
>                 Key: HBASE-17210
>                 URL: https://issues.apache.org/jira/browse/HBASE-17210
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: HBASE-17120.v1.patch
>
>
> Now when we want to get a row lock, the timeout is fixed and default is 30s. But the requests from client have different RPC timeout setting. We can use the client's deadline to set timeout on tryLock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)