[GitHub] [camel-k] squakez commented on a diff in pull request #3197: chore(deps): library upgrade

[GitBox <gi...@apache.org>]

squakez commented on code in PR #3197:
URL: https://github.com/apache/camel-k/pull/3197#discussion_r849289730


##########
pkg/util/olm/operator.go:
##########
@@ -122,7 +123,7 @@ func HasPermissionToInstall(ctx context.Context, client client.Client, namespace
 	}
 
 	if !global {
-		if ok, err := kubernetes.CheckPermission(ctx, client, operatorsv1.GroupName, "operatorgroups", namespace, options.Package, "list"); err != nil {

Review Comment:
   The `v1alpha1` is using `operators.GroupName` behind the scene: https://github.com/operator-framework/api/blob/v0.13.0/pkg/operators/v1alpha1/register.go#L13 - I'd be inclined to keep this value as it is the value expected by that package and let the API manages. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org