You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/02 21:05:03 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #7303:
[AIRFLOW-6691] Add tests that protect the deprecated packages
potiuk commented on a change in pull request #7303: [AIRFLOW-6691] Add tests that protect the deprecated packages
URL: https://github.com/apache/airflow/pull/7303#discussion_r373874920
##########
File path: tests/test_project_structure.py
##########
@@ -23,15 +23,29 @@
ROOT_FOLDER = os.path.realpath(
os.path.join(os.path.dirname(os.path.realpath(__file__)), os.pardir)
)
-CORE_EXAMPLE_DAGS_FOLDER = os.path.join(ROOT_FOLDER, "airflow", "example_dags")
-class TestExampleDags(unittest.TestCase):
- def test_reference_to_providers_is_illegal(self):
- for filename in glob.glob(f"{CORE_EXAMPLE_DAGS_FOLDER}/**.py"):
+class TestProjectStructure(unittest.TestCase):
+ def test_reference_to_providers_from_core(self):
+ for filename in glob.glob(f"{ROOT_FOLDER}/example_dagss/**.py", recursive=True):
Review comment:
```suggestion
for filename in glob.glob(f"{ROOT_FOLDER}/example_dags/**.py", recursive=True):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services