You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/29 17:15:25 UTC

[GitHub] [beam] steveniemitz edited a comment on pull request #11849: [BEAM-9964] Move workerCacheMb to a user-visible place

steveniemitz edited a comment on pull request #11849:
URL: https://github.com/apache/beam/pull/11849#issuecomment-636086069


   If you look at [DataflowPipelineOptions](https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java) it doesn't include `DataflowWorkerHarnessOptions`.  In fact, `DataflowWorkerHarnessOptions` implement `DataflowPipelineOptions` instead.  The harness options are used in the harness itself, while the `DataflowPipelineOptions` are what are validated against in the dataflow runner.
   
   edit: Also to clarify, user's don't (in general) directly implement `DataflowPipelineOptions`, they're included implicitly when the dataflow runner is used.  One could specifically implement `DataflowWorkerHarnessOptions` (or even just define the property in any options they have, we actually used to just do that) if they wanted to.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org