You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2023/04/21 09:48:32 UTC
[GitHub] [spark] allisonwang-db commented on a diff in pull request #40865: [SPARK-43156][SQL] Fix `COUNT(*) is null` bug in correlated scalar subquery
allisonwang-db commented on code in PR #40865:
URL: https://github.com/apache/spark/pull/40865#discussion_r1173566280
##########
sql/core/src/test/resources/sql-tests/results/subquery/scalar-subquery/scalar-subquery-count-bug.sql.out:
##########
@@ -106,14 +106,14 @@ from l
-- !query schema
struct<a:int,b:decimal(2,1),scalarsubquery(a):boolean>
-- !query output
-1 2.0 NULL
Review Comment:
These results are incorrect. They should be `NULL` instead of `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org