You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/04/18 18:51:41 UTC
[jira] [Commented] (COUCHDB-3378) Fix mango full text detection
[ https://issues.apache.org/jira/browse/COUCHDB-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973274#comment-15973274 ]
ASF subversion and git services commented on COUCHDB-3378:
----------------------------------------------------------
Commit 4c350081d82c3fd11cc4ba7630bf379912fa490c in couchdb's branch refs/heads/COUCHDB-3378-fix-mango-full-text-detection from [~paul.joseph.davis]
[ https://gitbox.apache.org/repos/asf?p=couchdb.git;h=4c35008 ]
Fix mango full text detection
The check for whether full text support in mango is available was broken
in that the mango_cursor_text module is only compiled if dreyfus exists
while the check to use the module was a runtime check. Thus is a user
were to add dreyfus after mango had been compiled it would have led to a
runtime error when we attempted to use a module that didn't exist.
This changes the check to a compile time check in both places. And now
that its a compile time define we can remove the need to rename source
files around which causes problems with source control seeing that file
change depending on local configuration.
COUCHDB-3378
> Fix mango full text detection
> -----------------------------
>
> Key: COUCHDB-3378
> URL: https://issues.apache.org/jira/browse/COUCHDB-3378
> Project: CouchDB
> Issue Type: Bug
> Components: Mango
> Reporter: Paul Joseph Davis
>
> The renaming of source files for mango's full text adapter was not super awesome. So I fixed it to not do that. PR incoming.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)