You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/05/10 12:12:33 UTC
[GitHub] [cordova-android] jcesarmobile opened a new pull request #1233: feat: Upgrade gradle to 7.0
jcesarmobile opened a new pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu edited a comment on pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233#issuecomment-872017997
Per Gradle Docs:
https://docs.gradle.org/current/userguide/single_versions.html
> A prefix version range: e.g. 1.+, 1.3.+
> Only versions exactly matching the portion before the + are included.
> The range + on it’s own will include any version.
Following their docs, I believe `6.7.1+` means only patch versions starting from `6.7.1` is supported. It wouldn't even cover minor releases.
> > Only versions exactly matching the portion before the + are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233#issuecomment-872017997
Per Gradle Docs:
https://docs.gradle.org/current/userguide/single_versions.html
> A prefix version range: e.g. 1.+, 1.3.+
> Only versions exactly matching the portion before the + are included.
> The range + on it’s own will include any version.
`6.7.1+` means onlys `6.7.x` is supported, not even the minor.
> > Only versions exactly matching the portion before the + are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu edited a comment on pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233#issuecomment-872017997
Per Gradle Docs:
https://docs.gradle.org/current/userguide/single_versions.html
> A prefix version range: e.g. 1.+, 1.3.+
> Only versions exactly matching the portion before the + are included.
> The range + on it’s own will include any version.
Following their docs, `6.7.1+` means only patch versions starting from `6.7.1` is supported. It wouldn't even cover minor releases.
> > Only versions exactly matching the portion before the + are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu edited a comment on pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233#issuecomment-872003690
IMO, for this major release, upgrading to Gradle 7.x is not recommended.
Following Android documetation and the versioning system, the current released version of Android Gradle Plugin does not support Gradle 7.
https://developer.android.com/studio/releases/gradle-plugin#updating-gradle
* If we upgraded to 7.x can it be guaranteed that we will never face issues caused by using an unsupported version?
* Is there any other documentation provided by Android that contradicts the above page where tehy say 7.x is supported?
If anything, we can keep this PR open for next major release. Google has been working on AGP 7.0 which supports Gradle 7.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233#issuecomment-872003690
IMO, for this major release, upgrading to Gradle 7.x is not recommended.
Following Android documetation and the versioning system, the current released version of Android Gradle Plugin does not support Gradle 7.
https://developer.android.com/studio/releases/gradle-plugin#updating-gradle
* If we upgraded to 7.x can it be guaranteed that we will never face issues caused by using an unsupported version?
* Is there any other documentation provided by Android that contradicts the above page where tehy say 7.x is supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233#issuecomment-872029822
That is gradle docs, while the other are android docs, so I wouldn't trust google uses that system 😛
Gradle site says they have tested gradle 7 on gradle plugin 4.1, 4.2 and 7 alpha/beta
https://docs.gradle.org/7.0/userguide/compatibility.html#android
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233#issuecomment-872016351
It is supported, that table shows the minimum version, it says 6.7.1+
we updated Capacitor to gradle 7 without problems (on the project itself, but plugins or apps can still break depending on their gradle scripts if something they use was removed)
I'm ok if it doesn't get merged, the fact that tests didn't pass means some of our scripts don't work on gradle 7 and need a rewrite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile closed pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
jcesarmobile closed pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233#issuecomment-872030807
anyway, that would mean we need to downgrade as the PR is updating from 6.8.3 to 7.0.0, and you say we should be using 6.7.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu edited a comment on pull request #1233: feat: Upgrade gradle to 7.0
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1233:
URL: https://github.com/apache/cordova-android/pull/1233#issuecomment-872017997
Per Gradle Docs:
https://docs.gradle.org/current/userguide/single_versions.html
> A prefix version range: e.g. 1.+, 1.3.+
> Only versions exactly matching the portion before the + are included.
> The range + on it’s own will include any version.
`6.7.1+` means onlys `6.7.x` is supported, starting from `6.7.1`... This doesnt even cover minor releases.
> > Only versions exactly matching the portion before the + are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org