You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "andrijapanicsb (via GitHub)" <gi...@apache.org> on 2024/01/16 17:31:21 UTC
[PR] Update ManageInstances.vue [cloudstack]
andrijapanicsb opened a new pull request, #8519:
URL: https://github.com/apache/cloudstack/pull/8519
Minor UI updates, renameing "Import QCOW...." to "Import QCOW2....."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename "Import QCOW...." to "Import QCOW2....." [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8519:
URL: https://github.com/apache/cloudstack/pull/8519#issuecomment-1894217002
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8519?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`c3b77cb`)](https://app.codecov.io/gh/apache/cloudstack/commit/c3b77cb7b82bfe8e94b024e81e1721532da51a9c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 18.28% compared to head [(`fe5b231`)](https://app.codecov.io/gh/apache/cloudstack/pull/8519?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 4.39%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8519 +/- ##
============================================
- Coverage 18.28% 4.39% -13.89%
============================================
Files 4848 361 -4487
Lines 324301 28624 -295677
Branches 45561 4993 -40568
============================================
- Hits 59290 1258 -58032
+ Misses 256437 27227 -229210
+ Partials 8574 139 -8435
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8519/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8519/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8519/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.39% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8519?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename "Import QCOW...." to "Import QCOW2....." [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8519:
URL: https://github.com/apache/cloudstack/pull/8519#discussion_r1455455637
##########
ui/public/locales/en.json:
##########
@@ -675,9 +675,9 @@
"label.deploymentplanner": "Deployment planner",
"label.desc.db.stats": "Database Statistics",
"label.desc.importexportinstancewizard": "Import and export Instances to/from an existing VMware or KVM cluster.",
-"label.desc.import.ext.kvm.wizard": "Import libvirt domain from KVM Host",
-"label.desc.import.local.kvm.wizard": "Import QCOW image from Local Storage",
-"label.desc.import.shared.kvm.wizard": "Import QCOW image from Shared Storage",
+"label.desc.import.ext.kvm.wizard": "Import Instance from remote KVM host",
Review Comment:
ok, no is good never mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename "Import QCOW...." to "Import QCOW2....." [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8519:
URL: https://github.com/apache/cloudstack/pull/8519#issuecomment-1894980889
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename "Import QCOW...." to "Import QCOW2....." [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8519:
URL: https://github.com/apache/cloudstack/pull/8519#discussion_r1455091051
##########
ui/public/locales/en.json:
##########
@@ -675,9 +675,9 @@
"label.deploymentplanner": "Deployment planner",
"label.desc.db.stats": "Database Statistics",
"label.desc.importexportinstancewizard": "Import and export Instances to/from an existing VMware or KVM cluster.",
-"label.desc.import.ext.kvm.wizard": "Import libvirt domain from KVM Host",
-"label.desc.import.local.kvm.wizard": "Import QCOW image from Local Storage",
-"label.desc.import.shared.kvm.wizard": "Import QCOW image from Shared Storage",
+"label.desc.import.ext.kvm.wizard": "Import Instance from remote KVM host",
Review Comment:
is it really "remote"? this is a configured host in cloudstack is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename "Import QCOW...." to "Import QCOW2....." [cloudstack]
Posted by "andrijapanicsb (via GitHub)" <gi...@apache.org>.
andrijapanicsb commented on code in PR #8519:
URL: https://github.com/apache/cloudstack/pull/8519#discussion_r1455387197
##########
ui/public/locales/en.json:
##########
@@ -675,9 +675,9 @@
"label.deploymentplanner": "Deployment planner",
"label.desc.db.stats": "Database Statistics",
"label.desc.importexportinstancewizard": "Import and export Instances to/from an existing VMware or KVM cluster.",
-"label.desc.import.ext.kvm.wizard": "Import libvirt domain from KVM Host",
-"label.desc.import.local.kvm.wizard": "Import QCOW image from Local Storage",
-"label.desc.import.shared.kvm.wizard": "Import QCOW image from Shared Storage",
+"label.desc.import.ext.kvm.wizard": "Import Instance from remote KVM host",
Review Comment:
No, it's an external host (not part ACS, needs to run libvirt i.e. also NOT proxmox host) - so... hm it can be either "remote" or "external" KVM host - opinions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename "Import QCOW...." to "Import QCOW2....." [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8519:
URL: https://github.com/apache/cloudstack/pull/8519#issuecomment-1894977540
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename "Import QCOW...." to "Import QCOW2....." [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr merged PR #8519:
URL: https://github.com/apache/cloudstack/pull/8519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename "Import QCOW...." to "Import QCOW2....." [cloudstack]
Posted by "andrijapanicsb (via GitHub)" <gi...@apache.org>.
andrijapanicsb commented on PR #8519:
URL: https://github.com/apache/cloudstack/pull/8519#issuecomment-1898324170
@shwstppr @DaanHoogland - can we please include this one in the 4.19 RC3 (since we are crafting it as it seems) - this is a simple UI fixed, not code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename "Import QCOW...." to "Import QCOW2....." [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8519:
URL: https://github.com/apache/cloudstack/pull/8519#issuecomment-1894993328
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8519 (QA-JID-264)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org