You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/27 13:16:03 UTC

[GitHub] [rocketmq] lizhiboo commented on issue #2046: selectOneMessageQueue must select lastFailBroker

lizhiboo commented on issue #2046:
URL: https://github.com/apache/rocketmq/issues/2046#issuecomment-634652299


   > branch 4.7.0
   > class MQFaultStrategy
   > row 68
   > if (null == lastBrokerName || mq.getBrokerName().equals(lastBrokerName))
   > it should be:
   > if (null == lastBrokerName || !mq.getBrokerName().equals(lastBrokerName))
   
   As you say, if lastBrokerName is null, it will select one MessageQueue, assuming MessageQueue-a. If it occurs some exception while producing to MessageQueue-a, it will always select MessageQueue-a since then. Can you submit a pr to fix it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org