You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/22 03:01:26 UTC

[GitHub] [spark] LuciferYang opened a new pull request #35929: [SPARK-38619][TESTS] Clean up Junit api usage in scalatest

LuciferYang opened a new pull request #35929:
URL: https://github.com/apache/spark/pull/35929


   ### What changes were proposed in this pull request?
   This pr clean up Junit api usage in scalatest and replace them with native scalatest api.
   
   
   ### Why are the changes needed?
   Use scalatest api in scalatest and Junit api in Java test
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #35929: [SPARK-38619][TESTS] Clean up Junit api usage in scalatest

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35929:
URL: https://github.com/apache/spark/pull/35929#issuecomment-1075833974


   thanks all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #35929: [SPARK-38619][TESTS] Clean up Junit api usage in scalatest

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35929:
URL: https://github.com/apache/spark/pull/35929


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #35929: [SPARK-38619][TESTS] Clean up Junit api usage in scalatest

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35929:
URL: https://github.com/apache/spark/pull/35929#issuecomment-1075203908


   Is that all of them? yes good fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #35929: [SPARK-38619][TESTS] Clean up Junit api usage in scalatest

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35929:
URL: https://github.com/apache/spark/pull/35929#issuecomment-1075738045


   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LuciferYang commented on pull request #35929: [SPARK-38619][TESTS] Clean up Junit api usage in scalatest

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35929:
URL: https://github.com/apache/spark/pull/35929#issuecomment-1075244746


   Yes, that's all
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org