You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/04 23:10:58 UTC

[GitHub] [spark] srowen commented on a change in pull request #26029: [SPARK-29336][SQL] Fix the implementation of QuantileSummaries.merge (guarantee that the relativeError will be respected)

srowen commented on a change in pull request #26029: [SPARK-29336][SQL] Fix the implementation of QuantileSummaries.merge (guarantee that the relativeError will be respected)
URL: https://github.com/apache/spark/pull/26029#discussion_r331713559
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/QuantileSummaries.scala
 ##########
 @@ -47,7 +47,8 @@ class QuantileSummaries(
     val relativeError: Double,
     val sampled: Array[Stats] = Array.empty,
     val count: Long = 0L,
-    var compressed: Boolean = false) extends Serializable {
+    var compressed: Boolean = false)
 
 Review comment:
   Revert all the formatting-only changes like this one please, to keep it simple

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org