You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/12/09 02:06:09 UTC
[kudu-CR] [util] make Socket::SetTcpKeepAlive() available on macOS
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20765
Change subject: [util] make Socket::SetTcpKeepAlive() available on macOS
......................................................................
[util] make Socket::SetTcpKeepAlive() available on macOS
Change-Id: I52c6e48181480415fc5ebc1b804aa21d0491b584
---
M src/kudu/util/net/socket.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/20765/1
--
To view, visit http://gerrit.cloudera.org:8080/20765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52c6e48181480415fc5ebc1b804aa21d0491b584
Gerrit-Change-Number: 20765
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [util] make Socket::SetTcpKeepAlive() available on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20765 )
Change subject: [util] make Socket::SetTcpKeepAlive() available on macOS
......................................................................
Patch Set 1: Verified+1
unrelated test failure in KeepAlivePeriodically
--
To view, visit http://gerrit.cloudera.org:8080/20765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52c6e48181480415fc5ebc1b804aa21d0491b584
Gerrit-Change-Number: 20765
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 09 Dec 2023 18:24:31 +0000
Gerrit-HasComments: No
[kudu-CR] [util] make Socket::SetTcpKeepAlive() available on macOS
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20765 )
Change subject: [util] make Socket::SetTcpKeepAlive() available on macOS
......................................................................
[util] make Socket::SetTcpKeepAlive() available on macOS
Change-Id: I52c6e48181480415fc5ebc1b804aa21d0491b584
Reviewed-on: http://gerrit.cloudera.org:8080/20765
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/util/net/socket.cc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I52c6e48181480415fc5ebc1b804aa21d0491b584
Gerrit-Change-Number: 20765
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [util] make Socket::SetTcpKeepAlive() available on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [util] make Socket::SetTcpKeepAlive() available on macOS
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I52c6e48181480415fc5ebc1b804aa21d0491b584
Gerrit-Change-Number: 20765
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] make Socket::SetTcpKeepAlive() available on macOS
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20765 )
Change subject: [util] make Socket::SetTcpKeepAlive() available on macOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52c6e48181480415fc5ebc1b804aa21d0491b584
Gerrit-Change-Number: 20765
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2023 18:10:09 +0000
Gerrit-HasComments: No
[kudu-CR] [util] make Socket::SetTcpKeepAlive() available on macOS
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20765 )
Change subject: [util] make Socket::SetTcpKeepAlive() available on macOS
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52c6e48181480415fc5ebc1b804aa21d0491b584
Gerrit-Change-Number: 20765
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Sun, 10 Dec 2023 17:36:08 +0000
Gerrit-HasComments: No