[jira] [Commented] (COUCHDB-833) Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace

["Sam Bisbee (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213182#comment-13213182 ] 

Sam Bisbee commented on COUCHDB-833:
------------------------------------

I just did a cursory review of where we use SHA1 in Futon and was under whelmed. As far as I can tell it's really only used in the tests even though it's included in every Futon page (creating a different issue for this).

If someone cares enough about Futon tests' run time then we could replace the SHA1 implementation, but it doesn't seem like a worthwhile cause to me.

Cheers.
                
> Use Takanori Ishikawa's JS SHA1 implementation which doesn't pollute the global namespace
> -----------------------------------------------------------------------------------------
>
>                 Key: COUCHDB-833
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-833
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Futon
>            Reporter: Devin Torres
>            Priority: Trivial
>         Attachments: better_js_sha1.patch, better_js_sha1.patch
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> The current implementation by Paj is slow and pollutes the global namespace with variables and functions. This implementation only exports the SHA1 module  and also happens to be up to 3 times faster as an added bonus. See http://bit.ly/9wjjRG for benchmarks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira