You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/19 06:34:49 UTC

[GitHub] [hbase] infraio commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

infraio commented on a change in pull request #1782:
URL: https://github.com/apache/hbase/pull/1782#discussion_r442656839



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1244,4 +1244,11 @@ public synchronized void renameRSGroup(String oldName, String newName) throws IO
     setRSGroup(updateTables, newName);
   }
 
+  @Override
+  public synchronized void updateRSGroupConfig(String groupName, Map<String, String> configuration)
+      throws IOException {
+    RSGroupInfo rsGroupInfo = getRSGroupInfo(groupName);

Review comment:
       Add one log here? Update from xxx to xxx?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org