[GitHub] [superset] betodealmeida edited a comment on issue #17852: [SIP-78] Proposal for Business Types

[GitBox <gi...@apache.org>]

betodealmeida edited a comment on issue #17852:
URL: https://github.com/apache/superset/issues/17852#issuecomment-999797862


   This is great! A couple comments:
   
   1. `BaseColumn` is going away (https://github.com/apache/superset/issues/14909 and https://github.com/apache/superset/pull/17543) in the next few weeks, so I wonder if we should wait a little and implement this directly in the new `Column` model.
   2. Instead of having this in the config, we could leverage [Python entry points](https://amir.rachum.com/blog/2017/07/28/python-entry-points/) to have a plugin system, like @rusackas mentioned. This way we can have a builtin set of business types that comes with Superset, and admins can develop, distribute, and install custom business types that would be automatically discovered by Superset. Best of both worlds! :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org