[GitHub] [superset] michael-s-molina commented on pull request #24429: fix: Viz migration adjustments - 2

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on PR #24429:
URL: https://github.com/apache/superset/pull/24429#issuecomment-1609398934

   > I see we have a function called `_migrate_temporal_filter` as we migrate more viz in the future, is a test needed to make sure we return the right data when calling this function?
   
   Hi @sadpandajoe. I added tests for this function at the migrations level but we can definitely move the tests to the base class in the next batch of migrations in 4.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org