You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/11/10 11:29:27 UTC
[GitHub] [incubator-mxnet] bgawrych opened a new pull request #19509: Unique names for nodes in imperative mode
bgawrych opened a new pull request #19509:
URL: https://github.com/apache/incubator-mxnet/pull/19509
## Description ##
Graph recorded in imperative mode doesn't have unique nodes name.
```
{
"op": "FullyConnected",
"name": "FullyConnected",
"attrs": {
"__profiler_scope__": "<unk>:",
"flatten": "False",
"no_bias": "False",
"num_hidden": "768"
},
"inputs": [[98, 0, 0], [99, 0, 0], [100, 0, 0]]
},
{
"op": "Dropout",
"name": "Dropout",
"attrs": {
"__profiler_scope__": "<unk>:",
"axes": "()",
"cudnn_off": "False",
"p": "0.1"
},
"inputs": [[101, 0, 0]]
},
```
E.g. every FC layer has the same name "FullyConnected". Because of this user is not able to identify nodes when using monitor callback (register_op_hook).
This PR changes node name to unique name if op name is equal to node name
@leezu @sxjscience
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19509: Unique names for nodes in imperative mode
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19509:
URL: https://github.com/apache/incubator-mxnet/pull/19509#issuecomment-724643476
Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, windows-cpu, clang, centos-cpu, edge, centos-gpu, windows-gpu, unix-gpu, miscellaneous, unix-cpu, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on pull request #19509: Unique names for nodes in imperative mode
Posted by GitBox <gi...@apache.org>.
sxjscience commented on pull request #19509:
URL: https://github.com/apache/incubator-mxnet/pull/19509#issuecomment-724913369
@leezu Does this look good to you? Should we merge this in first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19509: Unique names for nodes in imperative mode
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19509:
URL: https://github.com/apache/incubator-mxnet/pull/19509#issuecomment-724806983
Jenkins CI successfully triggered : [windows-gpu, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #19509: Unique names for nodes in imperative mode
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #19509:
URL: https://github.com/apache/incubator-mxnet/pull/19509#issuecomment-724806899
@mxnet-bot run ci [unix-gpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #19509: Unique names for nodes in imperative mode
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19509:
URL: https://github.com/apache/incubator-mxnet/pull/19509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org