[GitHub] [hive] vineetgarg02 commented on a change in pull request #1212: HIVE-23807 Wrong results with vectorization enabled

[GitBox <gi...@apache.org>]

vineetgarg02 commented on a change in pull request #1212:
URL: https://github.com/apache/hive/pull/1212#discussion_r450945185



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDate.java
##########
@@ -116,14 +118,16 @@ public void evaluate(VectorizedRowBatch batch) {
 
   private void evaluate(LongColumnVector outV, BytesColumnVector inV, int i) {
     String dateString = new String(inV.vector[i], inV.start[i], inV.length[i], StandardCharsets.UTF_8);
-    if (dateParser.parseDate(dateString, sqlDate)) {
+    try {
+      Date utilDate = Date.valueOf(dateString);

Review comment:
       Yes this vectorized expression is generated for `GenericUDFDate`.  I don't see any way to trigger precommit job manually for branch-2. @kgyrtkirk  Do you know how can I trigger ptest for branch-2?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org