You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2017/12/06 06:41:27 UTC
[cordova-browser] 03/04: CB-13614 Fix tests for windows style paths
This is an automated email from the ASF dual-hosted git repository.
purplecabbage pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-browser.git
commit 6fd835553d98553928643b2643db75e237fc79f3
Author: George Campbell <ca...@oclc.org>
AuthorDate: Thu Nov 30 16:34:03 2017 -0500
CB-13614 Fix tests for windows style paths
---
spec/browser_handler.spec.js | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/spec/browser_handler.spec.js b/spec/browser_handler.spec.js
index 4f9145e..1654b75 100644
--- a/spec/browser_handler.spec.js
+++ b/spec/browser_handler.spec.js
@@ -24,8 +24,8 @@ var path = require('path');
describe('Asset install tests', function () {
var fsstatMock;
- var asset = { itemType: 'asset', src: 'someSrc/ServiceWorker.js', target: 'ServiceWorker.js' };
- var assetPath = { itemType: 'asset', src: 'someSrc/reformat.js', target: 'js/deepdown/reformat.js' };
+ var asset = { itemType: 'asset', src: path.join('someSrc', 'ServiceWorker.js'), target: 'ServiceWorker.js' };
+ var assetWithPath = { itemType: 'asset', src: path.join('someSrc', 'reformat.js'), target: path.join('js', 'deepdown', 'reformat.js') };
var plugin_dir = 'pluginDir';
var wwwDest = 'dest';
@@ -51,7 +51,7 @@ describe('Asset install tests', function () {
spyOn(fs, 'statSync').and.returnValue(fsstatMock);
browser_handler.asset.install(asset, plugin_dir, wwwDest);
expect(mkdir).not.toHaveBeenCalled();
- expect(cp).toHaveBeenCalledWith('-f', 'pluginDir/someSrc/ServiceWorker.js', 'dest/ServiceWorker.js');
+ expect(cp).toHaveBeenCalledWith('-f', path.join('pluginDir', 'someSrc', 'ServiceWorker.js'), path.join('dest', 'ServiceWorker.js'));
});
it('if src is not a directory and asset has a path, should be called with cp, -f', function () {
var cp = spyOn(shell, 'cp').and.returnValue('-f');
@@ -62,8 +62,8 @@ describe('Asset install tests', function () {
}
};
spyOn(fs, 'statSync').and.returnValue(fsstatMock);
- browser_handler.asset.install(assetPath, plugin_dir, wwwDest);
- expect(mkdir).toHaveBeenCalledWith('-p', 'dest/js/deepdown');
- expect(cp).toHaveBeenCalledWith('-f', 'pluginDir/someSrc/reformat.js', 'dest/js/deepdown/reformat.js');
+ browser_handler.asset.install(assetWithPath, plugin_dir, wwwDest);
+ expect(mkdir).toHaveBeenCalledWith('-p', path.join('dest', 'js', 'deepdown'));
+ expect(cp).toHaveBeenCalledWith('-f', path.join('pluginDir', 'someSrc', 'reformat.js'), path.join('dest', 'js', 'deepdown', 'reformat.js'));
});
});
--
To stop receiving notification emails like this one, please contact
"commits@cordova.apache.org" <co...@cordova.apache.org>.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org