You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/12 15:40:52 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
xiaoxiang781216 opened a new pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398
## Summary
Make.defs under board folder can still overwrite the default as needed
## Impact
No funciton change.
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398#issuecomment-658690099
@xiaoxiang781216 There are some conflicts due to merging #1403 which deleted some of the stm32f4discovery Make.defs
While we are at it, I just merged Brennan's EOS S3 board, could you also make the same change to its Make.defs?
Should be just:
```diff
diff --git a/boards/arm/eoss3/quickfeather/scripts/Make.defs b/boards/arm/eoss3/quickfeather/scripts/Make.defs
index 802913f28a..6d6b7e34c7 100644
--- a/boards/arm/eoss3/quickfeather/scripts/Make.defs
+++ b/boards/arm/eoss3/quickfeather/scripts/Make.defs
@@ -61,7 +61,6 @@ ARCHPICFLAGS = -fpic -msingle-pic-base -mpic-register=r10
ifeq ($(CONFIG_ARMV7M_TOOLCHAIN_CLANGL),y)
ARCHCCVERSION = {shell $(CC) -v 2>&1 | sed -n '/clang version/p' | sed -e 's/.* clang version \([0-9\.]\)/\1/g' -e 's/[-\ ].*//g'}
- HOSTCC = clang
CC = clang
CXX = clang++
CPP = clang -E
@@ -69,7 +68,6 @@ ifeq ($(CONFIG_ARMV7M_TOOLCHAIN_CLANGL),y)
ARCHCXXFLAGS += -nostdlib -ffreestanding -target arm-none-eabi -march=armv7-m -mcpu=cortex-m4 -DCONFIG_WCHAR_BUILTIN
else
ARCHCCVERSION = ${shell $(CC) -v 2>&1 | sed -n '/^gcc version/p' | sed -e 's/^gcc version \([0-9\.]\)/\1/g' -e 's/[-\ ].*//g' -e '1q'}
- HOSTCC = gcc
CC = $(CROSSDEV)gcc
CXX = $(CROSSDEV)g++
CPP = $(CROSSDEV)gcc -E
@@ -92,4 +90,3 @@ NXFLATLDFLAGS1 = -r -d -warn-common
NXFLATLDFLAGS2 = $(NXFLATLDFLAGS1) -T$(TOPDIR)/binfmt/libnxflat/gnu-nxflat-pcrel.ld -no-check-sections
LDNXFLATFLAGS = -e main -s 2048
-HOSTCFLAGS = -Wall -Wstrict-prototypes -Wshadow -Wundef -g -pipe
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398#discussion_r453413894
##########
File path: boards/arm/stm32/b-g474e-dpow1/scripts/Make.defs
##########
@@ -85,10 +85,6 @@ endif
# Provide map file needed by the "Memory Allocation" view in Eclipse:
LDFLAGS += -Map=$(TOPDIR)/NuttX.map --gc-sections
-HOSTCC = gcc
-HOSTINCLUDES = -I.
Review comment:
there might be code doing #include <xxx.h> where xxx.h is in the current directory.
i don't feel strongly either ways though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398#issuecomment-658703073
Thanks Xiang.
@btashton just FYI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398#discussion_r453414678
##########
File path: boards/arm/stm32/b-g474e-dpow1/scripts/Make.defs
##########
@@ -85,10 +85,6 @@ endif
# Provide map file needed by the "Memory Allocation" view in Eclipse:
LDFLAGS += -Map=$(TOPDIR)/NuttX.map --gc-sections
-HOSTCC = gcc
-HOSTINCLUDES = -I.
Review comment:
In this case, the code is better to change #include "xxx.h" to indicate the intention explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398#discussion_r453406740
##########
File path: boards/arm/stm32/b-g474e-dpow1/scripts/Make.defs
##########
@@ -85,10 +85,6 @@ endif
# Provide map file needed by the "Memory Allocation" view in Eclipse:
LDFLAGS += -Map=$(TOPDIR)/NuttX.map --gc-sections
-HOSTCC = gcc
-HOSTINCLUDES = -I.
Review comment:
isn't this "-I." necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398#discussion_r453414678
##########
File path: boards/arm/stm32/b-g474e-dpow1/scripts/Make.defs
##########
@@ -85,10 +85,6 @@ endif
# Provide map file needed by the "Memory Allocation" view in Eclipse:
LDFLAGS += -Map=$(TOPDIR)/NuttX.map --gc-sections
-HOSTCC = gcc
-HOSTINCLUDES = -I.
Review comment:
In this case, the code is better to change #include "xxx.h".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398#discussion_r453412389
##########
File path: boards/arm/stm32/b-g474e-dpow1/scripts/Make.defs
##########
@@ -85,10 +85,6 @@ endif
# Provide map file needed by the "Memory Allocation" view in Eclipse:
LDFLAGS += -Map=$(TOPDIR)/NuttX.map --gc-sections
-HOSTCC = gcc
-HOSTINCLUDES = -I.
Review comment:
No, because many boards don't add -I. without any problem, and C compiler search the current directory by default(#include "xxx.h".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1398: boards: Move HOSTCC/HOSTCFLAGS to tools/Config.mk
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1398:
URL: https://github.com/apache/incubator-nuttx/pull/1398#issuecomment-658694479
@Ouss4 thanks for point out, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org