You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/22 15:32:51 UTC

[GitHub] [airflow] karan5291 opened a new pull request #5313: AIRFLOW-4295. Make comparison of attribute `method` case insensitive …

karan5291 opened a new pull request #5313: AIRFLOW-4295. Make comparison of attribute `method` case insensitive …
URL: https://github.com/apache/airflow/pull/5313
 
 
   This PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-4295)
   (It is a reopened version of  https://github.com/apache/airflow/pull/5173)
   
   ### Description
   Make the method `run` in the HttpHook compare the attribute 'method' in a case insensitive way. This resolves the issue where a Httphook created with parameter `method='get'` would not be treated as a GET-request in the run method and the attribute `params`would be omitted in the Http request.
   
   ### Tests
   
   - Unit tests: `test_hook_with_method_in_lowercase`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services