You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/03 03:46:00 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #8080: [AIRFLOW-4785] Don't apply limits on running DummyOperator

mik-laj commented on a change in pull request #8080: [AIRFLOW-4785] Don't apply limits on running DummyOperator
URL: https://github.com/apache/airflow/pull/8080#discussion_r402721192
 
 

 ##########
 File path: airflow/models/baseoperator.py
 ##########
 @@ -386,8 +386,8 @@ def __init__(
         self.retries = retries
         self.queue = queue
         self.pool = pool
-        self.pool_slots = pool_slots
-        if self.pool_slots < 1:
+        self.pool_slots = 0 if self.__class__.__name__ == 'DummyOperator' else pool_slots
+        if self.pool_slots < 0 or (self.pool_slots == 0 and self.__class__.__name__ != 'DummyOperator'):
 
 Review comment:
   Will this work with ExternalTaskMarker?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services