[GitHub] [superset] ktmud edited a comment on pull request #15699: perf(dashboard): make loading datasets non-blocking

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #15699:
URL: https://github.com/apache/superset/pull/15699#issuecomment-880924867


   > Have we verified yet that none of the chart plugins use datasets? If so we should also stop passing datasets to the charts.
   
   Thanks for pointing this out. I did more vetting and realized that some charts do use info on `datasource`, mostly non-critical info such as column name `verboseMap` here: https://github.com/apache-superset/superset-ui/blob/61accc6ce9c546331b7407cde21d6ec163fe191d/plugins/legacy-plugin-chart-pivot-table/src/transformProps.js
   
   Fixed a re-render issue now that charts will be updated accordingly once datasets are loaded:
   
   https://user-images.githubusercontent.com/335541/125838954-c30b276b-24e2-4612-97c8-60d97f931065.mp4
   
   Notice the name of the first column. It uses `verbose_map` and updated after `/datasets` is fully loaded. Note that I artificially slowed down the `/datasets` API. For most users, this minor update may not be even noticeable.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org