You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2020/07/10 13:09:12 UTC
[GitHub] [syncope] mmoayyed opened a new pull request #202: NOJIRA: Allow push ops to WA to reload services
mmoayyed opened a new pull request #202:
URL: https://github.com/apache/syncope/pull/202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a change in pull request #202: NOJIRA: Allow push ops to WA to reload services
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on a change in pull request #202:
URL: https://github.com/apache/syncope/pull/202#discussion_r452835697
##########
File path: common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/ClientAppService.java
##########
@@ -131,4 +131,11 @@
@Path("{type}/{key}")
@Produces({ MediaType.APPLICATION_JSON, RESTHeaders.APPLICATION_YAML, MediaType.APPLICATION_XML })
void delete(@NotNull @PathParam("type") ClientAppType type, @NotNull @PathParam("key") String key);
+
+ @ApiResponses(
+ @ApiResponse(responseCode = "204", description = "Operation was successful"))
+ @POST
+ @Path("push")
+ @Produces({ MediaType.APPLICATION_JSON, RESTHeaders.APPLICATION_YAML, MediaType.APPLICATION_XML })
+ void push();
Review comment:
Would you mind renaming this method as `pushToWA`, similar to its equivalent in `SRARouteService#pushToSRA`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] mmoayyed merged pull request #202: NOJIRA: Allow push ops to WA to reload services
Posted by GitBox <gi...@apache.org>.
mmoayyed merged pull request #202:
URL: https://github.com/apache/syncope/pull/202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org