You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by bomeng <gi...@git.apache.org> on 2018/08/29 23:22:47 UTC

[GitHub] spark pull request #22276: [SPARK-25242][SQL] make sql config setting fluent

GitHub user bomeng opened a pull request:

    https://github.com/apache/spark/pull/22276

    [SPARK-25242][SQL] make sql config setting fluent

    ## What changes were proposed in this pull request?
    
    User can now set conf more easily by doing this:
    ```
    sparkSession.conf.set(...).set(...).unset(...)
    ```
    
    ## How was this patch tested?
    
    More tests for those writings are added to the existing test cases.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bomeng/spark 25242

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22276
    
----
commit 45f438c650ae44662341f656378106bc31667f4d
Author: Bo Meng <bo...@...>
Date:   2018-08-29T23:10:09Z

    SPARK-25242: make sql config setting fluent

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by bomeng <gi...@git.apache.org>.

Github user bomeng commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    The tests failed due to method signatures' change, but it should not affect the existing test cases and  existing usages.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    Shall we leave this closed for now @bomeng ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    ?? This doesn't break source compatibility but breaks binary compatibility.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by bomeng <gi...@git.apache.org>.

Github user bomeng commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    Ok, closing....


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by maropu <gi...@git.apache.org>.

Github user maropu commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    You need to update `project/MimaExcludes.scala` in this case. Either way, we cannot touch stable interfaces now. I think you need to wait for branch-2.4 cut.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    **[Test build #95445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95445/testReport)** for PR 22276 at commit [`45f438c`](https://github.com/apache/spark/commit/45f438c650ae44662341f656378106bc31667f4d).
     * This patch **fails MiMa tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    We can think about this API change in 3.0 release. Now, Spark 2.4 release is not allowed to break the binary compatibility.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    **[Test build #95445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95445/testReport)** for PR 22276 at commit [`45f438c`](https://github.com/apache/spark/commit/45f438c650ae44662341f656378106bc31667f4d).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22276: [SPARK-25242][SQL] make sql config setting fluent

Posted by maropu <gi...@git.apache.org>.

Github user maropu commented on the issue:

    https://github.com/apache/spark/pull/22276
  
    oh, yes, this is the issue of binary compatibility...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org