You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/12/16 15:59:53 UTC

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4482: [Relay] External codegen

tqchen edited a comment on issue #4482: [Relay] External codegen
URL: https://github.com/apache/incubator-tvm/pull/4482#issuecomment-566122943
 
 
   Some additional comments on API design:
   
   - The keyword IsExternal is still quite confusing. I would suggest make the attribute "compiler", alternatively we can call it a "backend". When it is set, we will look up for the customized compiler hook. The value "default" invokes the default compilation pipeline. 
   
   - Let us deliberate a bit on the FuncName keyword. While I understand it is necessary to attach such attribute before lowering to that ensure consistent symbol lookup, is it the right name?
   
   More broadly, as we start to introduce more attributes to functions, it would be great to come up with a naming convention and document them

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services