You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/05/12 15:24:58 UTC

[GitHub] [geode] luissson commented on a change in pull request #6446: GEODE-9238: Restructure Hash-related DUnit tests to handle cluster mode

luissson commented on a change in pull request #6446:
URL: https://github.com/apache/geode/pull/6446#discussion_r631144411



##########
File path: geode-apis-compatible-with-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/hash/HashesAndCrashesDUnitTest.java
##########
@@ -147,6 +149,12 @@ public void after() {
     redisClient.shutdown();
   }
 
+  @AfterClass
+  public static void tearDown() {
+    server1.stop();
+    server2.stop();
+    server3.stop();
+  }

Review comment:
       I would get a failure from stress new test when starting up a server, complaining that a server could not be started because the port was in use. Stopping the servers after the tests completed appears to have resolved that. This follows the pattern I saw in other tests for example HScanDUnitTest




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org