You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/13 12:27:44 UTC

[GitHub] [hadoop-ozone] elek opened a new pull request #355: HDDS-2728. Remove methods of internal representation from DatanodeAdminMontor interface

elek opened a new pull request #355: HDDS-2728. Remove methods of internal representation from DatanodeAdminMontor interface 
URL: https://github.com/apache/hadoop-ozone/pull/355
 
 
   
   
    * `DatanodeAdminMonitorInterface` has some settesr and getters but they are not part of the contract they are used by the implementation. An other implementation of the interface may require different setters. Therefore the interface should contain only the required fields.
    *  `DatanodeAdminMonitorInterface` can be renamed to `DatanodeAdminMonitor` to follow the naming convention in the code (*Impl)
    * `PipelineManager` is unused field can be removed from `DatanodeAdminMonitorImpl`
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-2728
   
   ## How was this patch tested?
   
   With the existing Unit tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org