You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "javeme (GitHub)" <gi...@apache.org> on 2018/11/29 12:22:48 UTC

[GitHub] [tinkerpop] javeme opened pull request #1009: TINKERPOP-2106 throw TimeoutException instead of TraversalInterruptedException

https://issues.apache.org/jira/browse/TINKERPOP-2106

When gremlin executes timeout, it throws an error "TraversalInterruptedException: null".
According to our user feedback(https://github.com/hugegraph/hugegraph/issues/102), the message is not easy to understand. we think it is clearer if it prompts timeout error directly.

This commit converts some InterruptedException to a TimeoutException.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1009 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1009: TINKERPOP-2106 throw TimeoutException instead of TraversalInterruptedException

Posted by "spmallette (GitHub)" <gi...@apache.org>.
i was a bit hesitant about this one at first, but perhaps this makes sense. looking at the `TraversalOpProcessor`, it seems to have similar behavior converting the `TraversalInterruptionException` to a simple `TimeoutException`.  

All tests pass with `docker/build.sh -t -i`

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1009 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1009: TINKERPOP-2106 throw TimeoutException instead of TraversalInterruptedException

Posted by "spmallette (GitHub)" <gi...@apache.org>.
Merge to tp33/master with c923564065854901c62811bb42dd8ad0b938cc81

[ Full content available at: https://github.com/apache/tinkerpop/pull/1009 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette closed pull request #1009: TINKERPOP-2106 throw TimeoutException instead of TraversalInterruptedException

Posted by "spmallette (GitHub)" <gi...@apache.org>.
[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1009 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org