You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:17:11 UTC

[GitHub] [tvm] mbrookhart commented on a change in pull request #8193: [WIP] Update ONNX versions

mbrookhart commented on a change in pull request #8193:
URL: https://github.com/apache/tvm/pull/8193#discussion_r654540087



##########
File path: docker/install/ubuntu_install_onnx.sh
##########
@@ -20,9 +20,10 @@ set -e
 set -u
 set -o pipefail
 
-# fix to certain version for now
-pip3 install onnx==1.6.0
-pip3 install onnxruntime==1.0.0
+# We need to fix the onnx version because changing versions tends to break tests
+# TODO(mbrookhart): periodically update
+pip3 install onnx==1.8.0

Review comment:
       I'm not sure what there is to update? gen_requirements.py doesn't constrain the version of ONNX, and the goal here is to maintain backwards compatibility with old versions of onnx, that's why the importer supports opsets.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org