You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Deepak Nigam <de...@gmail.com> on 2019/01/23 04:33:12 UTC
Re: svn commit: r1851203 - in /ofbiz/ofbiz-framework/branches/release17.12:
./ framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
Hi Jacques,
When there is one web app with the empty mount point (i.e. deployed on
root), the auto-login cookie will not work for that particular webapp due
to the change in the path of the cookie from "/" to "/" + applicationName.
Because the system will try to find the cookie at the "/" but it is
actually at "/" + applicationName.
Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd
On Sun, Jan 13, 2019 at 7:13 PM <jl...@apache.org> wrote:
> Author: jleroux
> Date: Sun Jan 13 13:43:44 2019
> New Revision: 1851203
>
> URL: http://svn.apache.org/viewvc?rev=1851203&view=rev
> Log:
> "Applied fix from trunk for revision: 1851200"
> ------------------------------------------------------------------------
> r1851200 | jleroux | 2019-01-13 14:31:13 +0100 (dim. 13 janv. 2019) | 11
> lignes
>
> Reverted: Impossible secure and autologin cookie names when mountpoint
> contains
> a slash inside its name
> (OFBIZ-10766)
>
> In my previous commit I reverted the initial change. As I said in the Jira
> I had a second look and it's better to fix the problem at the root as I
> did
> initially.
>
> I wrote in my previous commit: "This method is used in other places where
> the
> name should not be changed." I checked there are no issues changing
> slashes to
> underscores in the cookies names anywhere.
> ------------------------------------------------------------------------
>
> Modified:
> ofbiz/ofbiz-framework/branches/release17.12/ (props changed)
>
> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>
> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>
> Propchange: ofbiz/ofbiz-framework/branches/release17.12/
>
> ------------------------------------------------------------------------------
> --- svn:mergeinfo (original)
> +++ svn:mergeinfo Sun Jan 13 13:43:44 2019
> @@ -10,4 +10,4 @@
> /ofbiz/branches/json-integration-refactoring:1634077-1635900
> /ofbiz/branches/multitenant20100310:921280-927264
> /ofbiz/branches/release13.07:1547657
>
> -/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
>
> 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163
>
> +/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
>
> 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163,1851200
>
> Modified:
> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java?rev=1851203&r1=1851202&r2=1851203&view=diff
>
> ==============================================================================
> ---
> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
> (original)
> +++
> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
> Sun Jan 13 13:43:44 2019
> @@ -668,7 +668,7 @@ public final class UtilHttp {
> if (request.getContextPath().length() > 1) {
> appName = request.getContextPath().substring(1);
> }
> - return appName;
> + return appName.replaceAll("/","_");
> }
>
> public static void setInitialRequestInfo(HttpServletRequest request) {
>
> Modified:
> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java?rev=1851203&r1=1851202&r2=1851203&view=diff
>
> ==============================================================================
> ---
> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
> (original)
> +++
> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
> Sun Jan 13 13:43:44 2019
> @@ -720,7 +720,7 @@ public class LoginWorker {
> Cookie autoLoginCookie = new
> Cookie(getAutoLoginCookieName(request), userLogin.getString("userLoginId"));
> autoLoginCookie.setMaxAge(60 * 60 * 24 * 365);
>
> autoLoginCookie.setDomain(EntityUtilProperties.getPropertyValue("url",
> "cookie.domain", delegator));
> - autoLoginCookie.setPath("/" +
> applicationName.replaceAll("/","_"));
> + autoLoginCookie.setPath("/" + applicationName);
> autoLoginCookie.setSecure(true);
> autoLoginCookie.setHttpOnly(true);
> response.addCookie(autoLoginCookie);
>
>
>
Re: svn commit: r1851203 - in
/ofbiz/ofbiz-framework/branches/release17.12: ./
framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Deepak,
I attached a patch at OFBIZ-10766, please try
Thanks
Jacques
Le 23/01/2019 à 09:10, Jacques Le Roux a écrit :
> Thanks Deepak,
>
> Yes indeed, replaceAll() does not fit. As I said in my comment I want to only replace the "inside" slashes.
>
> I'll fix that ASAP
>
> Jacques
>
> Le 23/01/2019 à 05:33, Deepak Nigam a écrit :
>> Hi Jacques,
>>
>> When there is one web app with the empty mount point (i.e. deployed on
>> root), the auto-login cookie will not work for that particular webapp due
>> to the change in the path of the cookie from "/" to "/" + applicationName.
>> Because the system will try to find the cookie at the "/" but it is
>> actually at "/" + applicationName.
>>
>> Thanks & Regards
>> --
>> Deepak Nigam
>> HotWax Systems Pvt. Ltd
>>
>>
>>
>> On Sun, Jan 13, 2019 at 7:13 PM <jl...@apache.org> wrote:
>>
>>> Author: jleroux
>>> Date: Sun Jan 13 13:43:44 2019
>>> New Revision: 1851203
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1851203&view=rev
>>> Log:
>>> "Applied fix from trunk for revision: 1851200"
>>> ------------------------------------------------------------------------
>>> r1851200 | jleroux | 2019-01-13 14:31:13 +0100 (dim. 13 janv. 2019) | 11
>>> lignes
>>>
>>> Reverted: Impossible secure and autologin cookie names when mountpoint
>>> contains
>>> a slash inside its name
>>> (OFBIZ-10766)
>>>
>>> In my previous commit I reverted the initial change. As I said in the Jira
>>> I had a second look and it's better to fix the problem at the root as I
>>> did
>>> initially.
>>>
>>> I wrote in my previous commit: "This method is used in other places where
>>> the
>>> name should not be changed." I checked there are no issues changing
>>> slashes to
>>> underscores in the cookies names anywhere.
>>> ------------------------------------------------------------------------
>>>
>>> Modified:
>>> ofbiz/ofbiz-framework/branches/release17.12/ (props changed)
>>>
>>> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>>>
>>> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>>>
>>> Propchange: ofbiz/ofbiz-framework/branches/release17.12/
>>>
>>> ------------------------------------------------------------------------------
>>> --- svn:mergeinfo (original)
>>> +++ svn:mergeinfo Sun Jan 13 13:43:44 2019
>>> @@ -10,4 +10,4 @@
>>> /ofbiz/branches/json-integration-refactoring:1634077-1635900
>>> /ofbiz/branches/multitenant20100310:921280-927264
>>> /ofbiz/branches/release13.07:1547657
>>>
>>> -/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
>>>
>>>
>>> 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163
>>>
>>> +/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
>>>
>>>
>>> 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163,1851200
>>>
>>> Modified:
>>> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java?rev=1851203&r1=1851202&r2=1851203&view=diff
>>>
>>>
>>> ==============================================================================
>>> ---
>>> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>>> (original)
>>> +++
>>> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>>> Sun Jan 13 13:43:44 2019
>>> @@ -668,7 +668,7 @@ public final class UtilHttp {
>>> if (request.getContextPath().length() > 1) {
>>> appName = request.getContextPath().substring(1);
>>> }
>>> - return appName;
>>> + return appName.replaceAll("/","_");
>>> }
>>>
>>> public static void setInitialRequestInfo(HttpServletRequest request) {
>>>
>>> Modified:
>>> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java?rev=1851203&r1=1851202&r2=1851203&view=diff
>>>
>>>
>>> ==============================================================================
>>> ---
>>> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>>> (original)
>>> +++
>>> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>>> Sun Jan 13 13:43:44 2019
>>> @@ -720,7 +720,7 @@ public class LoginWorker {
>>> Cookie autoLoginCookie = new
>>> Cookie(getAutoLoginCookieName(request), userLogin.getString("userLoginId"));
>>> autoLoginCookie.setMaxAge(60 * 60 * 24 * 365);
>>>
>>> autoLoginCookie.setDomain(EntityUtilProperties.getPropertyValue("url",
>>> "cookie.domain", delegator));
>>> - autoLoginCookie.setPath("/" +
>>> applicationName.replaceAll("/","_"));
>>> + autoLoginCookie.setPath("/" + applicationName);
>>> autoLoginCookie.setSecure(true);
>>> autoLoginCookie.setHttpOnly(true);
>>> response.addCookie(autoLoginCookie);
>>>
>>>
>>>
>
>
Re: svn commit: r1851203 - in
/ofbiz/ofbiz-framework/branches/release17.12: ./
framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Deepak,
Yes indeed, replaceAll() does not fit. As I said in my comment I want to only replace the "inside" slashes.
I'll fix that ASAP
Jacques
Le 23/01/2019 à 05:33, Deepak Nigam a écrit :
> Hi Jacques,
>
> When there is one web app with the empty mount point (i.e. deployed on
> root), the auto-login cookie will not work for that particular webapp due
> to the change in the path of the cookie from "/" to "/" + applicationName.
> Because the system will try to find the cookie at the "/" but it is
> actually at "/" + applicationName.
>
> Thanks & Regards
> --
> Deepak Nigam
> HotWax Systems Pvt. Ltd
>
>
>
> On Sun, Jan 13, 2019 at 7:13 PM <jl...@apache.org> wrote:
>
>> Author: jleroux
>> Date: Sun Jan 13 13:43:44 2019
>> New Revision: 1851203
>>
>> URL: http://svn.apache.org/viewvc?rev=1851203&view=rev
>> Log:
>> "Applied fix from trunk for revision: 1851200"
>> ------------------------------------------------------------------------
>> r1851200 | jleroux | 2019-01-13 14:31:13 +0100 (dim. 13 janv. 2019) | 11
>> lignes
>>
>> Reverted: Impossible secure and autologin cookie names when mountpoint
>> contains
>> a slash inside its name
>> (OFBIZ-10766)
>>
>> In my previous commit I reverted the initial change. As I said in the Jira
>> I had a second look and it's better to fix the problem at the root as I
>> did
>> initially.
>>
>> I wrote in my previous commit: "This method is used in other places where
>> the
>> name should not be changed." I checked there are no issues changing
>> slashes to
>> underscores in the cookies names anywhere.
>> ------------------------------------------------------------------------
>>
>> Modified:
>> ofbiz/ofbiz-framework/branches/release17.12/ (props changed)
>>
>> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>>
>> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>>
>> Propchange: ofbiz/ofbiz-framework/branches/release17.12/
>>
>> ------------------------------------------------------------------------------
>> --- svn:mergeinfo (original)
>> +++ svn:mergeinfo Sun Jan 13 13:43:44 2019
>> @@ -10,4 +10,4 @@
>> /ofbiz/branches/json-integration-refactoring:1634077-1635900
>> /ofbiz/branches/multitenant20100310:921280-927264
>> /ofbiz/branches/release13.07:1547657
>>
>> -/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
>>
>> 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163
>>
>> +/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
>>
>> 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163,1851200
>>
>> Modified:
>> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java?rev=1851203&r1=1851202&r2=1851203&view=diff
>>
>> ==============================================================================
>> ---
>> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>> (original)
>> +++
>> ofbiz/ofbiz-framework/branches/release17.12/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
>> Sun Jan 13 13:43:44 2019
>> @@ -668,7 +668,7 @@ public final class UtilHttp {
>> if (request.getContextPath().length() > 1) {
>> appName = request.getContextPath().substring(1);
>> }
>> - return appName;
>> + return appName.replaceAll("/","_");
>> }
>>
>> public static void setInitialRequestInfo(HttpServletRequest request) {
>>
>> Modified:
>> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java?rev=1851203&r1=1851202&r2=1851203&view=diff
>>
>> ==============================================================================
>> ---
>> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>> (original)
>> +++
>> ofbiz/ofbiz-framework/branches/release17.12/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
>> Sun Jan 13 13:43:44 2019
>> @@ -720,7 +720,7 @@ public class LoginWorker {
>> Cookie autoLoginCookie = new
>> Cookie(getAutoLoginCookieName(request), userLogin.getString("userLoginId"));
>> autoLoginCookie.setMaxAge(60 * 60 * 24 * 365);
>>
>> autoLoginCookie.setDomain(EntityUtilProperties.getPropertyValue("url",
>> "cookie.domain", delegator));
>> - autoLoginCookie.setPath("/" +
>> applicationName.replaceAll("/","_"));
>> + autoLoginCookie.setPath("/" + applicationName);
>> autoLoginCookie.setSecure(true);
>> autoLoginCookie.setHttpOnly(true);
>> response.addCookie(autoLoginCookie);
>>
>>
>>