You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by dk...@apache.org on 2009/06/19 21:47:08 UTC
svn commit: r786638 - in /cxf/trunk:
common/common/src/main/java/org/apache/cxf/common/i18n/
rt/core/src/main/java/org/apache/cxf/wsdl11/
Author: dkulp
Date: Fri Jun 19 19:47:08 2009
New Revision: 786638
URL: http://svn.apache.org/viewvc?rev=786638&view=rev
Log:
[CXF-2295] Add better error message
Modified:
cxf/trunk/common/common/src/main/java/org/apache/cxf/common/i18n/UncheckedException.java
cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/Messages.properties
cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLRuntimeException.java
cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLServiceBuilder.java
Modified: cxf/trunk/common/common/src/main/java/org/apache/cxf/common/i18n/UncheckedException.java
URL: http://svn.apache.org/viewvc/cxf/trunk/common/common/src/main/java/org/apache/cxf/common/i18n/UncheckedException.java?rev=786638&r1=786637&r2=786638&view=diff
==============================================================================
--- cxf/trunk/common/common/src/main/java/org/apache/cxf/common/i18n/UncheckedException.java (original)
+++ cxf/trunk/common/common/src/main/java/org/apache/cxf/common/i18n/UncheckedException.java Fri Jun 19 19:47:08 2009
@@ -19,6 +19,9 @@
package org.apache.cxf.common.i18n;
+import java.util.ResourceBundle;
+import java.util.logging.Logger;
+
public class UncheckedException extends java.lang.RuntimeException {
@@ -41,7 +44,29 @@
message = null;
}
-
+ public UncheckedException(Logger log, String msg, Object ... params) {
+ message = new org.apache.cxf.common.i18n.Message(msg,
+ log,
+ params);
+ }
+ public UncheckedException(ResourceBundle bundle, String msg, Object ... params) {
+ message = new org.apache.cxf.common.i18n.Message(msg,
+ bundle,
+ params);
+ }
+ public UncheckedException(Logger log, String msg, Throwable t, Object ... params) {
+ super(t);
+ message = new org.apache.cxf.common.i18n.Message(msg,
+ log,
+ params);
+ }
+ public UncheckedException(ResourceBundle bundle, String msg, Throwable t, Object ... params) {
+ super(t);
+ message = new org.apache.cxf.common.i18n.Message(msg,
+ bundle,
+ params);
+ }
+
public String getCode() {
if (null != message) {
return message.getCode();
Modified: cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/Messages.properties
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/Messages.properties?rev=786638&r1=786637&r2=786638&view=diff
==============================================================================
--- cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/Messages.properties (original)
+++ cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/Messages.properties Fri Jun 19 19:47:08 2009
@@ -30,3 +30,4 @@
MISSING_DESTINATION_FACTORY = Cannot find the destination factory, check the port //wsdl:port[@name=''{0}'']
MISSING_SERVICE= No definition of service {0} in the WSDL.
WSDL4J_BAD_ELEMENT_PART= Part {0} defined as element {1} which is not in the schema.
+NO_MESSAGE=No {0} message was found for operation {1} and input named {2}. Check the wsdl for errors.
Modified: cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLRuntimeException.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLRuntimeException.java?rev=786638&r1=786637&r2=786638&view=diff
==============================================================================
--- cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLRuntimeException.java (original)
+++ cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLRuntimeException.java Fri Jun 19 19:47:08 2009
@@ -19,6 +19,8 @@
package org.apache.cxf.wsdl11;
+import java.util.logging.Logger;
+
import org.apache.cxf.common.i18n.Message;
import org.apache.cxf.common.i18n.UncheckedException;
@@ -39,4 +41,9 @@
public WSDLRuntimeException(Throwable cause) {
super(cause);
}
+
+ public WSDLRuntimeException(Logger log, String msg, Object ... params) {
+ super(log, msg, params);
+ }
+
}
Modified: cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLServiceBuilder.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLServiceBuilder.java?rev=786638&r1=786637&r2=786638&view=diff
==============================================================================
--- cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLServiceBuilder.java (original)
+++ cxf/trunk/rt/core/src/main/java/org/apache/cxf/wsdl11/WSDLServiceBuilder.java Fri Jun 19 19:47:08 2009
@@ -570,6 +570,9 @@
this.copyExtensionAttributes(opInfo, op);
Input input = op.getInput();
if (input != null) {
+ if (input.getMessage() == null) {
+ throw new WSDLRuntimeException(LOG, "NO_MESSAGE", "input", op.getName(), input.getName());
+ }
MessageInfo minfo = opInfo.createMessage(input.getMessage().getQName(), MessageInfo.Type.INPUT);
opInfo.setInput(input.getName(), minfo);
buildMessage(minfo, input.getMessage());
@@ -578,6 +581,9 @@
}
Output output = op.getOutput();
if (output != null) {
+ if (output.getMessage() == null) {
+ throw new WSDLRuntimeException(LOG, "NO_MESSAGE", "output", op.getName(), output.getName());
+ }
MessageInfo minfo = opInfo.createMessage(output.getMessage().getQName(), MessageInfo.Type.OUTPUT);
opInfo.setOutput(output.getName(), minfo);
buildMessage(minfo, output.getMessage());