[GitHub] haojin2 commented on a change in pull request #12003: got rid of fixed seed for test_optimizer/test_operator_gpu.test_ftml

[GitBox <gi...@apache.org>]

haojin2 commented on a change in pull request #12003: got rid of fixed seed for test_optimizer/test_operator_gpu.test_ftml
URL: https://github.com/apache/incubator-mxnet/pull/12003#discussion_r207619733
 
 

 ##########
 File path: tests/python/unittest/test_optimizer.py
 ##########
 @@ -512,7 +512,10 @@ def update(self, index, weight, grad, state):
         prev_v[:] = v_t
         prev_z[:] = z_t
 
-@with_seed(0)
+# @mseth10: Getting rid of fixed seed. Flakiness was reproduced on GPU.
+# rtol and atol increased to 10x their default values to resolve it.
+# can be tracked at https://github.com/apache/incubator-mxnet/issues/11735
 
 Review comment:
   Feel free to remove those 3 lines of comment and simply link the issue in the description of the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services