You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "TszKitLo40 (via GitHub)" <gi...@apache.org> on 2023/04/28 01:32:07 UTC
[GitHub] [inlong] TszKitLo40 commented on a diff in pull request #7933: [INLONG-7926][TubeMQ] Add "Register2Master" method for GO SDK
TszKitLo40 commented on code in PR #7933:
URL: https://github.com/apache/inlong/pull/7933#discussion_r1179849093
##########
inlong-tubemq/tubemq-client-twins/tubemq-client-go/client/producer_impl.go:
##########
@@ -0,0 +1,200 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package client
+
+import (
+ "context"
+ "os"
+ "strconv"
+ "strings"
+ "sync"
+ "sync/atomic"
+ "time"
+
+ "github.com/apache/inlong/inlong-tubemq/tubemq-client-twins/tubemq-client-go/config"
+ "github.com/apache/inlong/inlong-tubemq/tubemq-client-twins/tubemq-client-go/log"
+ "github.com/apache/inlong/inlong-tubemq/tubemq-client-twins/tubemq-client-go/metadata"
+ "github.com/apache/inlong/inlong-tubemq/tubemq-client-twins/tubemq-client-go/multiplexing"
+ "github.com/apache/inlong/inlong-tubemq/tubemq-client-twins/tubemq-client-go/protocol"
+ "github.com/apache/inlong/inlong-tubemq/tubemq-client-twins/tubemq-client-go/rpc"
+ "github.com/apache/inlong/inlong-tubemq/tubemq-client-twins/tubemq-client-go/selector"
+ "github.com/apache/inlong/inlong-tubemq/tubemq-client-twins/tubemq-client-go/transport"
+ "github.com/apache/inlong/inlong-tubemq/tubemq-client-twins/tubemq-client-go/util"
+)
+
+type producer struct {
+ clientID string
+ config *config.Config
+ nextAuth2Master int32
+ selector selector.Selector
+ master *selector.Node
+ client rpc.RPCClient
+ masterHBRetry int
+ unreportedTimes int
+ publishTopics []string
+ brokerCheckSum int64
+ brokerMap map[string]*metadata.Node
+ brokerMu sync.Mutex
+}
+
+// NewProducer returns a producer which is constructed by a given config.
+func NewProducer(config *config.Config) (Producer, error) {
+ if err := config.ValidateProducer(); err != nil {
+ return nil, err
+ }
+ log.Infof("The config of the producer is %s", config)
+
+ selector, err := selector.Get("ip")
+ if err != nil {
+ return nil, err
+ }
+
+ clientID := newProducerClientID()
+ pool := multiplexing.NewPool()
+ opts := &transport.Options{}
+ if config.Net.TLS.Enable {
+ opts.TLSEnable = true
+ opts.CACertFile = config.Net.TLS.CACertFile
+ opts.TLSCertFile = config.Net.TLS.TLSCertFile
+ opts.TLSKeyFile = config.Net.TLS.TLSKeyFile
+ opts.TLSServerName = config.Net.TLS.TLSServerName
+ }
+
+ client := rpc.New(pool, opts, config)
+
+ p := &producer{
+ config: config,
+ clientID: clientID,
+ selector: selector,
+ client: client,
+ unreportedTimes: 0,
+ brokerMap: make(map[string]*metadata.Node),
+ publishTopics: config.Producer.Topics,
+ }
+
+ err = p.register2Master(true)
+ if err != nil {
+ return nil, err
+ }
+
+ log.Infof("[PRODUCER] start producer success, client=%s", clientID)
+ return p, nil
+}
+
+func (p *producer) register2Master(needChange bool) error {
+ if needChange {
+ p.selector.Refresh(p.config.Producer.Masters)
+ node, err := p.selector.Select(p.config.Producer.Masters)
+ if err != nil {
+ return err
+ }
+ p.master = node
+ }
+
+ retryCount := 0
+ for {
+ rsp, err := p.sendRegRequest2Master()
+ if err != nil || !rsp.GetSuccess() {
+ if err != nil {
+ log.Errorf("[PRODUCER]register2Master error %s", err.Error())
+ }
+ if !p.master.HasNext {
+ if err != nil {
+ return err
+ }
+ if rsp != nil {
+ log.Errorf("[PRODUCER] register2Master(%s) failure exist register, client=%s, errCode: %d, errorMsg: %s",
+ p.master.Address, p.clientID, rsp.GetErrCode(), rsp.GetErrMsg())
+ }
+ break
+ }
+ retryCount++
+ log.Warnf("[PRODUCER] register2master(%s) failure, client=%s, retry count=%d",
+ p.master.Address, p.clientID, retryCount)
+ if p.master, err = p.selector.Select(p.config.Consumer.Masters); err != nil {
+ return err
+ }
+ continue
+ }
+ log.Infof("register2Master response %s", rsp.String())
+ p.masterHBRetry = 0
+ p.processRegisterResponseM2P(rsp)
+ break
+ }
+ return nil
+}
+
+func (p *producer) sendRegRequest2Master() (*protocol.RegisterResponseM2P, error) {
+ ctx, cancel := context.WithTimeout(context.Background(), p.config.Net.ReadTimeout)
+ defer cancel()
+
+ m := &metadata.Metadata{}
+ node := &metadata.Node{}
+ node.SetHost(util.GetLocalHost())
+ node.SetAddress(p.master.Address)
+
+ auth := &protocol.AuthenticateInfo{}
+ if p.needGenMasterCertificateInfo(true) {
+ util.GenMasterAuthenticateToken(auth, p.config.Net.Auth.UserName, p.config.Net.Auth.Password)
+ }
+
+ m.SetNode(node)
+
+ rsp, err := p.client.RegisterRequestP2M(ctx, m, p.clientID)
+ return rsp, err
+}
+
+func (p *producer) processRegisterResponseM2P(rsp *protocol.RegisterResponseM2P) {
+ p.brokerCheckSum = rsp.GetBrokerCheckSum()
+ brokerInfos := rsp.GetBrokerInfos()
+ p.updateBrokerInfoList(brokerInfos)
+}
+
+func newProducerClientID() string {
Review Comment:
It is nearly the same logic of `newClient` in `consumer.go`. How about making it as an util function?
##########
inlong-tubemq/tubemq-client-twins/tubemq-client-go/client/producer.go:
##########
@@ -0,0 +1,21 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package client
+
+type Producer interface {
Review Comment:
Is there any function of Producer interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org