You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/22 23:20:50 UTC

[GitHub] [hudi] nsivabalan opened a new pull request, #7037: [HUDI-5078] Is table service replace commit

nsivabalan opened a new pull request, #7037:
URL: https://github.com/apache/hudi/pull/7037

   ### Change Logs
   
   While applying commit metadata to metadata table, there is an argument "isTableService" to determine whether the triggering action is a table service or not. We mistakenly considered any replace commit as table service. Right fix is, only clustering is table service and other replace commits are not. 
   
   ### Impact
   
   Metadata compaction will make progress with replace commit actions like INSERT_OVERRIDE after this patch. 
   
   ### Risk level (write none, low medium or high below)
   
   low.
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1305214210

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12475",
       "triggerID" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b2d84de42e2818bd6b12f53c5564caa767ec2ca0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12475) 
   * 6b24d087d34e72823b4c83d48d1000bcb1865609 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1014078055


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -858,10 +860,22 @@ public final Option<HoodieTableMetadataWriter> getMetadataWriter(String triggeri
 
   /**
    * Check if action type is a table service.
-   * @param actionType action type of interest.
+   * @param instant instant of interest
    * @return true if action represents a table service. false otherwise.
    */
-  public abstract boolean isTableServiceAction(String actionType);
+  public boolean isTableServiceAction(HoodieInstant instant) {
+    if (instant.getAction().equals(HoodieTimeline.REPLACE_COMMIT_ACTION)) {
+      Option<Pair<HoodieInstant, HoodieClusteringPlan>> instantPlan = ClusteringUtils.getClusteringPlan(getMetaClient(), instant);

Review Comment:
   ```suggestion
         Option<Pair<HoodieInstant, HoodieClusteringPlan>> instantPlan = ClusteringUtils.getClusteringPlan(metaClient, instant);
   ```



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java:
##########
@@ -58,7 +59,7 @@ public BaseActionExecutor(HoodieEngineContext context, HoodieWriteConfig config,
    */
   protected final void writeTableMetadata(HoodieCommitMetadata metadata, String actionType) {
     table.getMetadataWriter(instantTime).ifPresent(w -> w.update(
-        metadata, instantTime, table.isTableServiceAction(actionType)));
+        metadata, instantTime, table.isTableServiceAction(new HoodieInstant(HoodieInstant.State.INFLIGHT, actionType, instantTime))));

Review Comment:
   not a big fan of creating dummy instant to cater the API. it's the API that needs to fit better with the caller info.



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -656,7 +659,9 @@ private List<DirectoryInfo> listAllPartitions(HoodieTableMetaClient datasetMetaC
           partitionsToBootstrap.add(dirInfo);
         } else {
           // Add sub-dirs to the queue
-          pathsToList.addAll(dirInfo.getSubDirectories());
+          pathsToList.addAll(dirInfo.getSubDirectories().stream()
+              .map(path -> new SerializablePath(new CachingPath(path.toUri())))
+              .collect(Collectors.toList()));
         }

Review Comment:
   unrelated changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1344864843

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320",
       "triggerID" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13420",
       "triggerID" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "afb7e32ef944898d2ea52e365692c4aac8624ca5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13596",
       "triggerID" : "afb7e32ef944898d2ea52e365692c4aac8624ca5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c3cf14ae5e70c0667020076d3d788965c8ad12d1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13420) 
   * afb7e32ef944898d2ea52e365692c4aac8624ca5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13596) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] danny0405 commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1035485604


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -349,7 +349,7 @@ protected void preCommit(HoodieInstant inflightInstant, HoodieCommitMetadata met
   protected void writeTableMetadata(HoodieTable table, String instantTime, String actionType, HoodieCommitMetadata metadata) {
     context.setJobStatus(this.getClass().getSimpleName(), "Committing to metadata table: " + config.getTableName());
     table.getMetadataWriter(instantTime).ifPresent(w -> ((HoodieTableMetadataWriter) w).update(metadata, instantTime,
-        table.isTableServiceAction(actionType)));
+        table.isTableServiceAction(new HoodieInstant(State.INFLIGHT, actionType, instantTime))));
   }

Review Comment:
   Can we just pass around the `actionType` and `instantTime` instead of constructing the dummy instant on the fly ?
   The instant can be constructed lazily within method `#isTableServiceAction `.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1335789870

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320",
       "triggerID" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2ce44c56f16fda8ba477e11df62539e3922d0f87 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320) 
   * c3cf14ae5e70c0667020076d3d788965c8ad12d1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1335847865

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320",
       "triggerID" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13420",
       "triggerID" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2ce44c56f16fda8ba477e11df62539e3922d0f87 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320) 
   * c3cf14ae5e70c0667020076d3d788965c8ad12d1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13420) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1305514039

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12475",
       "triggerID" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b24d087d34e72823b4c83d48d1000bcb1865609 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1330745908

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b24d087d34e72823b4c83d48d1000bcb1865609 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828) 
   * 2ce44c56f16fda8ba477e11df62539e3922d0f87 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1044099173


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java:
##########
@@ -67,7 +67,7 @@ public enum State {
     // Committed instant
     COMPLETED,
     // Invalid instant
-    INVALID
+    NIL

Review Comment:
   just to confirm no such state can be persisted in any way for actual usage, and it is only meant for testing. By this logic, we should avoid putting this as part of production code, esp. as public API. Can we take this chance to move it to test code? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1305220420

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12475",
       "triggerID" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b2d84de42e2818bd6b12f53c5564caa767ec2ca0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12475) 
   * 6b24d087d34e72823b4c83d48d1000bcb1865609 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] nsivabalan merged pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
nsivabalan merged PR #7037:
URL: https://github.com/apache/hudi/pull/7037


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Is table service replace commit

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1287987292

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12475",
       "triggerID" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b2d84de42e2818bd6b12f53c5564caa767ec2ca0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12475) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] nsivabalan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1015081511


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -656,7 +659,9 @@ private List<DirectoryInfo> listAllPartitions(HoodieTableMetaClient datasetMetaC
           partitionsToBootstrap.add(dirInfo);
         } else {
           // Add sub-dirs to the queue
-          pathsToList.addAll(dirInfo.getSubDirectories());
+          pathsToList.addAll(dirInfo.getSubDirectories().stream()
+              .map(path -> new SerializablePath(new CachingPath(path.toUri())))
+              .collect(Collectors.toList()));
         }

Review Comment:
   yeah my bad. mixed up w/ another patch. 
   will revert it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1044630751


##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java:
##########
@@ -67,7 +67,7 @@ public enum State {
     // Committed instant
     COMPLETED,
     // Invalid instant
-    INVALID
+    NIL

Review Comment:
   as discussed, scratch the part of moving to test code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] nsivabalan commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1305198613

   @xushiyan : feel free to take another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1330757123

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320",
       "triggerID" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b24d087d34e72823b4c83d48d1000bcb1865609 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828) 
   * 2ce44c56f16fda8ba477e11df62539e3922d0f87 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1344861401

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320",
       "triggerID" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13420",
       "triggerID" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "afb7e32ef944898d2ea52e365692c4aac8624ca5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "afb7e32ef944898d2ea52e365692c4aac8624ca5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c3cf14ae5e70c0667020076d3d788965c8ad12d1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13420) 
   * afb7e32ef944898d2ea52e365692c4aac8624ca5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1331333944

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320",
       "triggerID" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2ce44c56f16fda8ba477e11df62539e3922d0f87 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] nsivabalan commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1335770851

   I did not want to introduce another overloaded method for 
   ```
   ClusteringUtils.getClusteringPlan(
   ```
   So, have kept it just for that use-case. have removed elsehwere. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] nsivabalan commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1335775067

   @xushiyan @danny0405 : addressed all reviews


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1016342441


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java:
##########
@@ -58,7 +59,7 @@ public BaseActionExecutor(HoodieEngineContext context, HoodieWriteConfig config,
    */
   protected final void writeTableMetadata(HoodieCommitMetadata metadata, String actionType) {
     table.getMetadataWriter(instantTime).ifPresent(w -> w.update(
-        metadata, instantTime, table.isTableServiceAction(actionType)));
+        metadata, instantTime, table.isTableServiceAction(new HoodieInstant(HoodieInstant.State.INFLIGHT, actionType, instantTime))));

Review Comment:
   @nsivabalan seeing there is `org.apache.hudi.common.table.timeline.HoodieInstant.State#INVALID` which is only used by tests, so we can change it to something like `NIL` and use it for this scenario? At least to make it clear that this is a dummy instant, better than marking it inflight.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] nsivabalan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1015084533


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java:
##########
@@ -58,7 +59,7 @@ public BaseActionExecutor(HoodieEngineContext context, HoodieWriteConfig config,
    */
   protected final void writeTableMetadata(HoodieCommitMetadata metadata, String actionType) {
     table.getMetadataWriter(instantTime).ifPresent(w -> w.update(
-        metadata, instantTime, table.isTableServiceAction(actionType)));
+        metadata, instantTime, table.isTableServiceAction(new HoodieInstant(HoodieInstant.State.INFLIGHT, actionType, instantTime))));

Review Comment:
   we need entire HoodieInstant to get the clstuering plan. so not sure what other option we have. If you have any solution, let me know. happy to incorporate. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Is table service replace commit

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1287954791

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b2d84de42e2818bd6b12f53c5564caa767ec2ca0 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1307304759

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b24d087d34e72823b4c83d48d1000bcb1865609 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1335934754

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320",
       "triggerID" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13420",
       "triggerID" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c3cf14ae5e70c0667020076d3d788965c8ad12d1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13420) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] codope commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
codope commented on code in PR #7037:
URL: https://github.com/apache/hudi/pull/7037#discussion_r1037239812


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -349,7 +349,7 @@ protected void preCommit(HoodieInstant inflightInstant, HoodieCommitMetadata met
   protected void writeTableMetadata(HoodieTable table, String instantTime, String actionType, HoodieCommitMetadata metadata) {
     context.setJobStatus(this.getClass().getSimpleName(), "Committing to metadata table: " + config.getTableName());
     table.getMetadataWriter(instantTime).ifPresent(w -> ((HoodieTableMetadataWriter) w).update(metadata, instantTime,
-        table.isTableServiceAction(actionType)));
+        table.isTableServiceAction(new HoodieInstant(State.INFLIGHT, actionType, instantTime))));
   }

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Is table service replace commit

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1287957146

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12475",
       "triggerID" : "b2d84de42e2818bd6b12f53c5564caa767ec2ca0",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b2d84de42e2818bd6b12f53c5564caa767ec2ca0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12475) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1306861384

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b24d087d34e72823b4c83d48d1000bcb1865609 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1306870981

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6b24d087d34e72823b4c83d48d1000bcb1865609 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7037:
URL: https://github.com/apache/hudi/pull/7037#issuecomment-1345105082

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12828",
       "triggerID" : "6b24d087d34e72823b4c83d48d1000bcb1865609",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13320",
       "triggerID" : "2ce44c56f16fda8ba477e11df62539e3922d0f87",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13420",
       "triggerID" : "c3cf14ae5e70c0667020076d3d788965c8ad12d1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "afb7e32ef944898d2ea52e365692c4aac8624ca5",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13596",
       "triggerID" : "afb7e32ef944898d2ea52e365692c4aac8624ca5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * afb7e32ef944898d2ea52e365692c4aac8624ca5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13596) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org