You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/14 05:23:24 UTC
[GitHub] [apisix] tzssangglass opened a new pull request #6100: feat(ngx_tpl): fix position of apisix_mirror_on_demand
tzssangglass opened a new pull request #6100:
URL: https://github.com/apache/apisix/pull/6100
Closes #6095
Signed-off-by: tzssangglass <tz...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6100: feat(ngx_tpl): fix position of apisix_mirror_on_demand
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6100:
URL: https://github.com/apache/apisix/pull/6100#discussion_r784554788
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -270,7 +270,6 @@ http {
{% if use_apisix_openresty then %}
Review comment:
Should move the whole block out from the access_log stuff...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #6100: feat(ngx_tpl): fix position of apisix_mirror_on_demand
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #6100:
URL: https://github.com/apache/apisix/pull/6100#discussion_r784594503
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -270,7 +270,6 @@ http {
{% if use_apisix_openresty then %}
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6100: fix(ngx_tpl): fix position of apisix_mirror_on_demand
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6100:
URL: https://github.com/apache/apisix/pull/6100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org